Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rootdirs causing typescript to think non-existent relative paths are ok #77

Open
osdiab opened this issue Jul 24, 2018 · 0 comments

Comments

@osdiab
Copy link
Member

osdiab commented Jul 24, 2018

In server and client in order to make typescript not yell about shared not existing i added shared to rootdirs for those packages, but this also means that it thinks that the source of shared is literally accessible through relative paths (it's a virtual src folder that includes both of them)

typescript composite packages, which haven't been released just yet, solve this problem to the best of my knowledge: microsoft/TypeScript#25600

If we use that we can also simplify the publish script for client since only having the real rootDir will cause the dist directory to flatten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant