Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeClimate checks do not seem to work any more #2148

Closed
1 task
christianbrb opened this issue Sep 21, 2020 · 9 comments
Closed
1 task

CodeClimate checks do not seem to work any more #2148

christianbrb opened this issue Sep 21, 2020 · 9 comments
Assignees
Labels
3 bug 🕷️ Something isn't working infrastructure 🚧 Tests, CI, and general project infrastructure Ready 🎬 Issues which are ready to be pulled into the iteration

Comments

@christianbrb
Copy link
Contributor

Description

After reading #2147 I have checked CodeClimate and the code quality seemed to get worse within the last 2 months.

grafik

It does not seem to get checked any more within a PR (see eg. #2146).

Acceptance criteria

  • Every PR is checked

Tasks

@christianbrb christianbrb added bug 🕷️ Something isn't working infrastructure 🚧 Tests, CI, and general project infrastructure labels Sep 21, 2020
@christianbrb christianbrb added this to the Product Backlog milestone Sep 21, 2020
@christianbrb
Copy link
Contributor Author

christianbrb commented Sep 25, 2020

CodeClimate was stuck. Removed from the required checks. Maybe this was due to @kelsos leaving the team (token or oAuth?).

@christianbrb christianbrb added the Ready 🎬 Issues which are ready to be pulled into the iteration label Sep 25, 2020
@kelsos
Copy link
Contributor

kelsos commented Sep 25, 2020

@christianbrb Was I the one that created the codeclimate configuration?

@kelsos
Copy link
Contributor

kelsos commented Sep 25, 2020

At least from what I see, I cannot access the repo settings for the projects on code climate anymore as excepted. Maybe you can go to the site log in with the github account and check the repo settings tab.

https://docs.codeclimate.com/docs/github-pull-requests#pull-request-statuses

The screenshot is from one of my own projects that has codeclimate activated.
image

Maybe they changed something that requires extra actions

@christianbrb
Copy link
Contributor Author

@kelsos Great :) Thanks for the quick feedback :)

@taleldayekh taleldayekh added the 3 label Sep 30, 2020
@taleldayekh taleldayekh removed this from the Product Backlog milestone Sep 30, 2020
@palango palango self-assigned this Oct 5, 2020
@palango
Copy link
Contributor

palango commented Oct 5, 2020

I enabled CodeClimate again for the light client repository. Looks like that now:

Screenshot 2020-10-05 at 14 31 51

Looks like that for me now. However, I still don't see the according check in the GitHub settings. @kelsos Do you remember how you enabled that?

@palango
Copy link
Contributor

palango commented Oct 5, 2020

It works in #2197

Screenshot 2020-10-05 at 14 58 14
According to the requirements that's all to do. Is there anything more that used to be done @christianbrb ? The technical dept is still higher than in summer.

@kelsos
Copy link
Contributor

kelsos commented Oct 5, 2020

Out of curiosity @palango any idea why it stopped working, was it because I left the organization?

@palango
Copy link
Contributor

palango commented Oct 5, 2020

Out of curiosity @palango any idea why it stopped working, was it because I left the organization?

No, I don't know. Andre removed the branch check at some point because it wasn't working, but maybe it really was disabled because you left the team.

@palango
Copy link
Contributor

palango commented Oct 5, 2020

Done with the check marked as required for PRs to master.

@palango palango closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 bug 🕷️ Something isn't working infrastructure 🚧 Tests, CI, and general project infrastructure Ready 🎬 Issues which are ready to be pulled into the iteration
Projects
None yet
Development

No branches or pull requests

4 participants