-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully handle Ctrl-c and Escape #49
Labels
bug
Something isn't working
Comments
@rajasegar what do you think about adding a hacktoberfest label? it could help many people know about alacritty-themes. |
Sounds good to me |
@JuanVqz Added the label to the repo as well |
you already did it, thank you, what else can we add with the hacktoberfest label? BTW I'm about to add a contributors section in the readme, are you agree? |
Yes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all I'd like to thank for the convenient tool to pick themes. There are some issues I've discovered:
1: The app incorrectly handles Ctrl-c:
If the interrupt sequence is pressed fast enough, it catches the app in the middle of writing to alacritty.yml, leaving it half-written. The result is the broken config:
The app should trap C-c and finish the cleanup first
2: The app incorrectly handles Esc:
Expected: the selection process aborts, leaving the previous theme
Actual: a theme under cursor is applied like if Enter was pressed.
The text was updated successfully, but these errors were encountered: