Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor base layout solution more robust #503

Open
gordlin opened this issue Jan 7, 2025 · 0 comments
Open

Make editor base layout solution more robust #503

gordlin opened this issue Jan 7, 2025 · 0 comments
Assignees
Labels
Priority: Low This task can is low priority and can wait if high priority tasks exist Refactor A refactor related to restructuring codebase UI/UX Issues related to a UI change

Comments

@gordlin
Copy link
Member

gordlin commented Jan 7, 2025

Description

The current base layout solution requires hardcoded heights. This means that, if any of the components changes their height, the layout gets thrown around.

Image
Notice the double scrollbar. The editor itself shouldn't have one, but since the height of the header isn't the hardcoded height, the layout breaks.

Is your feature request related to a problem?

With the current solution, if we want to change any of the main layout elements, we need to change the hardcoded heights every time.

Proposed solution

While keeping the same layout, refactor the current solution to be more robust. It shouldn't break if element heights change

Alternatives considered

CSS Grid might work.

@gordlin gordlin added Priority: Low This task can is low priority and can wait if high priority tasks exist Refactor A refactor related to restructuring codebase UI/UX Issues related to a UI change labels Jan 7, 2025
@gordlin gordlin self-assigned this Jan 7, 2025
This was referenced Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Low This task can is low priority and can wait if high priority tasks exist Refactor A refactor related to restructuring codebase UI/UX Issues related to a UI change
Projects
None yet
Development

No branches or pull requests

1 participant