Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting a product causes unsaved changes indicator and reset changes button to appear #509

Open
mohsin-r opened this issue Jan 13, 2025 · 1 comment
Labels
Bug Something isn't working

Comments

@mohsin-r
Copy link
Member

Description

What the title says.

Environment

All.

Steps to reproduce

  1. Load your favourite product.
  2. Go to main editor tab.
  3. Hit export without making any changes.
  4. Get groused at for having unsaved changes.

Expected behavior

There should be no unsaved changes indicator/reset changes button.

Actual behavior

There is an indicator and a button.

@mohsin-r mohsin-r added the Bug Something isn't working label Jan 13, 2025
@RyanCoulsonCA
Copy link
Member

Same thing happens if you open the edit metadata modal and then click "View French Config".

One common function that's called in both of these cases is loadSlides(), which replaces the undefined slides with an empty object.

This slide change is getting picked up by onSlidesEdited in editor.vue, which fires any time this.slides is updated and sets unsavedChanges to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants