Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text preview layout doesn't match storyline layout #548

Open
james-rae opened this issue Feb 18, 2025 · 1 comment
Open

Text preview layout doesn't match storyline layout #548

james-rae opened this issue Feb 18, 2025 · 1 comment
Labels
Bug Something isn't working Discussion New Student Text/Markdown Issues concerning markdown editing, text, or embedded HTML support

Comments

@james-rae
Copy link
Member

Description

The text input is markdownish.
The preview pane will respect a single line break.
The actual storyline will not.
The actual storyline also renders the backquotes, though it's applying their style.

Screenshots

Image

Image

And the actual storyline.
Image

Actual behavior

Should respect same convention. Will leave it up to devs to decide which is preferred one.
Markdown backquotes should not appear on site.

@james-rae james-rae added the Bug Something isn't working label Feb 18, 2025
@szczz szczz added Discussion Text/Markdown Issues concerning markdown editing, text, or embedded HTML support Meeting Topic topic for future meeting and removed Meeting Topic topic for future meeting labels Feb 18, 2025
@yileifeng
Copy link
Member

  1. Linebreaks not respected:

The Markdown editor preview adds a <br> tag for single line breaks. For Storylines layout to respect this, may require a code change directly in Storylines codebase by adding a breaks: true property to the MarkdownIt parser which is used to adjust for single line breaks based on its documentation. However if there is an alternative solution that can be applied directly in the text editor, that would be the ideal solution.

  1. Backticks appearing in preview:

Tailwind default class styles seem to be applying a psuedo class to the <code> element with the backquote set as the content. Potential solution is to overwrite this rule in tailwind.config.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Discussion New Student Text/Markdown Issues concerning markdown editing, text, or embedded HTML support
Projects
None yet
Development

No branches or pull requests

3 participants