From 7a7caece5d07acd7fb77063a25b1f663fc44d177 Mon Sep 17 00:00:00 2001 From: Pedro Tashima <23709916+tashima42@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:03:12 -0300 Subject: [PATCH 1/2] use eio secrets --- .github/workflows/release.yml | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6c0f5ee6..02ef5582 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -21,6 +21,12 @@ jobs: env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: gh release upload -R ${{ github.repository }} ${{ github.ref_name }} ${{ github.workspace }}/dist/* --clobber + - name: Load Secrets from Vault + uses: rancher-eio/read-vault-secrets@main + with: + secrets: | + secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials username | DOCKERHUB_USERNAME; + secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials password | DOCKERHUB_TOKEN; - name: Publish manifest uses: ./actions/publish-image with: @@ -34,5 +40,5 @@ jobs: # Docker as its Prime registry. prime-registry: docker.io prime-repo: rancher - prime-username: ${{ secrets.DOCKERHUB_USERNAME }} - prime-password: ${{ secrets.DOCKERHUB_TOKEN }} + prime-username: ${{ env.DOCKERHUB_USERNAME }} + prime-password: ${{ env.DOCKERHUB_TOKEN }} From 9779db26987e7676f06de1a54af32d17d60ab9ea Mon Sep 17 00:00:00 2001 From: Pedro Tashima <23709916+tashima42@users.noreply.github.com> Date: Thu, 5 Dec 2024 14:06:03 -0300 Subject: [PATCH 2/2] fix secrets identation --- .github/workflows/release.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 02ef5582..7c687daf 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -25,8 +25,8 @@ jobs: uses: rancher-eio/read-vault-secrets@main with: secrets: | - secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials username | DOCKERHUB_USERNAME; - secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials password | DOCKERHUB_TOKEN; + secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials username | DOCKERHUB_USERNAME; + secret/data/github/repo/${{ github.repository }}/dockerhub/rancher/credentials password | DOCKERHUB_TOKEN; - name: Publish manifest uses: ./actions/publish-image with: