-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Additionally publish public image to ghcr.io #17
Conversation
Signed-off-by: Víctor Cuadrado Juan <[email protected]>
@viccuad - This is good now I think. However this may want to wait until after the RFC is fully accepted. Granted I'm biased because I created the project and RFC to start using Once the RFC is approved by RAT, then it will be more certain as a fully supported solution though. However until that happens the future of this image/project is "uncertain" - since if not accepted we'd simply archive this repo most likely. That in mind, I will feel better if we hold off on merging this for now. To prevent publishing more images than the existing test images on DockerHub today. |
Many thanks for the fixes! |
@flavio - what's the status of the RFC mentioned by @mallardduck above ? |
The RFC has been approved on Oct 28 |
My team will begin to plan "official launch" of this project and a timeline integration into rancher. Once I have finalized those details I will merge this PR, then prepare necessary changes for release branches and tag the first releases. |
BTW, our official target for launch is Rancher 2.11 (in March). However I am anticipating the ability to backport these changes to prior versions of Rancher as well. To that end, we're tagging Doing this may seem odd at first, but it allows for us to publish older versions of this image that target older versions of Rancher. |
Push the public image also to ghcr.io, under https://github.com/orgs/rancher/packages.
I haven't tested the PR, as I wouldn't progress through the previous steps from my fork.
This is triggered by the desire to consume this image as part of Kubewarden, here. Kubewarden charts follow the convention on having a value
cattle.systemDefaultRegistry
, which we already have set asghcr.io
for the rest of images. Hence, continuing on serving from 1 repository alone and keeping the Rancher convention would be of help to us.