Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre select PID value table from Handbook #269

Open
cottec opened this issue Oct 19, 2022 · 3 comments
Open

Pre select PID value table from Handbook #269

cottec opened this issue Oct 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@cottec
Copy link
Contributor

cottec commented Oct 19, 2022

Might be easy for quick setup of standard values depending on machine type

@kjyv
Copy link
Collaborator

kjyv commented Oct 19, 2022

Do you mean to suggest a preset selection UI on the parameters page? There have been some ideas about this already but no one has taken the time to work on it - feel free to start ;)

@cottec
Copy link
Contributor Author

cottec commented Oct 19, 2022

Yeah or automatically load them depending on machine type in userconfig.h
Probably makes more sense to hardcode the standard settings for each machine type?
https://github.com/rancilio-pid/ranciliopid/blob/9bb3816a4f0c485dc99e01975b2b5ae1dbef0629/src/rancilio-pid.h#L16

@kjyv
Copy link
Collaborator

kjyv commented Oct 19, 2022

We are going to remove the config file completely in the near future, so pre-selecting the machine type won't be necessary anymore. I guess a first time setup-page would be nice asking for features, machine etc.

@murmeltier08 murmeltier08 added the enhancement New feature or request label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants