Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update - Forms #954

Open
9 tasks done
AbdellaToronto opened this issue Apr 6, 2021 · 1 comment
Open
9 tasks done

Update - Forms #954

AbdellaToronto opened this issue Apr 6, 2021 · 1 comment
Assignees
Labels
Spring 2021 Work Update - 2021 Updates current content in book during the 2021 update, for example, on out of date info

Comments

@AbdellaToronto
Copy link
Collaborator

AbdellaToronto commented Apr 6, 2021

Forms

  • Remove reference to Angular 1.x

Getting Started

Input Labeling

  • Second example not valid due to id being required for for=””

Template-Driven Forms

Nesting Form Data

  • Example needs to have for=”” and id on the
  • Remove first bullet-point of not needing IDs

Using Template Model Binding

  • Show how the first example would look like in the UI?

Validating Template-Driven Forms

  • Doesn’t explain that the form obj can be valid/invalid
  • Show the value within an Angular component upon submission?

Creating Functional Forms

  • Remove mention of ex-Ranglers?
  • Should this example be reworked with Ngrx ?
@AbdellaToronto AbdellaToronto added Spring 2021 Work Update - 2021 Updates current content in book during the 2021 update, for example, on out of date info labels Apr 6, 2021
@dmoriley-r
Copy link
Contributor

dmoriley-r commented Jul 12, 2021

The task for Input Labeling is talking about "id" and "for" attributes being required, in the second example the input tag is inside the label tag. The Mozilla docs says:

Alternatively, you can nest the <input> directly inside the <label>, in which case the for and id attributes are not needed because the association is implicit

Also this would be the case for the tasks under Nesting Form Data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Spring 2021 Work Update - 2021 Updates current content in book during the 2021 update, for example, on out of date info
Projects
None yet
Development

No branches or pull requests

2 participants