You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks for your reply. I agree the implementation matches the paper -- I think that equation 6 might itself be wrong, but it does make sense to stay consistent with the published version
Hi, thanks for your work on this package!
Is the calculation of the mc variance correct? (Line 137)
variance_mc = (sum(Jsf.^2)/ncalls - integral_mc^2) / (ncalls - 1) + eps()
I think it should be
variance_mc = (sum(Jsf.^2)/ncalls - integral_mc^2) * ncalls/(ncalls - 1) + eps()
to implement Bessel's correction properly.
The text was updated successfully, but these errors were encountered: