You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It's common across RAPIDS to build a wheel in one CI job and then use it in another one (for example, building librmm and then using that in a later job that builds rmm).
#69 documents some cases where overly-flexible approaches for passing those wheels between jobs led to CI failing to catch broken wheels.
It also documents an approach that was taken to prevent that... in pseudo-code:
Test the approach by following something like "how I tested this" from rapidsai/rmm#1586
Notes
Opened this to defer investigation it further in #69, but I (@jameslamb) want to note one reservation for whenever this is picked up.
Using --no-index --find-links ${DIR} probably means that ${DIR} needs to contain all build dependencies (e.g. scikit-build-core, Cython, etc.)... so scripts would have to somehow provide for filling that directory with those, e.g. with pip download.
If that's true, it might just be simpler to completely stop using build isolation (e.g. stop passing --no-build-isolation) in wheel build jobs and set up the build environment with e.g. pip install or pip download (and then passing the other wheels from CI via constraints like --constraint /opt/download/dist/*.whl).
The text was updated successfully, but these errors were encountered:
As discussed in #69 and #33, it seems like reasons are slowly piling up why we should just switch to building without isolation. Unfortunate, but so be it.
Description
It's common across RAPIDS to build a wheel in one CI job and then use it in another one (for example, building
librmm
and then using that in a later job that buildsrmm
).#69 documents some cases where overly-flexible approaches for passing those wheels between jobs led to CI failing to catch broken wheels.
It also documents an approach that was taken to prevent that... in pseudo-code:
In https://github.com/rapidsai/kvikio/pull/397/files#r1657898551, @jakirkham recommended considering instead doing something like the following:
pip wheel \ --no-index \ --find-links /opt/download/dist/ \ .
To close this issue, investigate that alternative approach and roll it out if it's found to be preferable.
Benefits of this work
Similar to #69, but with:
constraints.txt
fileAcceptance Criteria
Approach
Test the approach by following something like "how I tested this" from rapidsai/rmm#1586
Notes
Opened this to defer investigation it further in #69, but I (@jameslamb) want to note one reservation for whenever this is picked up.
Using
--no-index --find-links ${DIR}
probably means that${DIR}
needs to contain all build dependencies (e.g.scikit-build-core
,Cython
, etc.)... so scripts would have to somehow provide for filling that directory with those, e.g. withpip download
.If that's true, it might just be simpler to completely stop using build isolation (e.g. stop passing
--no-build-isolation
) in wheel build jobs and set up the build environment with e.g.pip install
orpip download
(and then passing the other wheels from CI via constraints like--constraint /opt/download/dist/*.whl
).The text was updated successfully, but these errors were encountered: