Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not all estimators match scikit-learn signature conventions #6255

Open
jcrist opened this issue Jan 23, 2025 · 0 comments
Open

[BUG] Not all estimators match scikit-learn signature conventions #6255

jcrist opened this issue Jan 23, 2025 · 0 comments
Assignees
Labels
? - Needs Triage Need team to review and classify bug Something isn't working

Comments

@jcrist
Copy link
Member

jcrist commented Jan 23, 2025

Not all estimators in cuml match the expected scikit-learn signatures for fit/fit_transform. In particular, many estimators are missing a y parameter to fit/fit_transform in cases where y would be ignored (but scikit-learn still requires it to be there). This can lead to issues when trying to switch between scikit-learn and cuml estimators.

We should:

  • Add a test that ensures the standard methods (fit/fit_transform/transform/predict) match the expected standard signatures
  • Fix cases where they don't
@jcrist jcrist added ? - Needs Triage Need team to review and classify bug Something isn't working labels Jan 23, 2025
@jcrist jcrist self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
? - Needs Triage Need team to review and classify bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant