Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should all models match the sklearn interface? #6258

Open
jcrist opened this issue Jan 24, 2025 · 0 comments
Open

Should all models match the sklearn interface? #6258

jcrist opened this issue Jan 24, 2025 · 0 comments

Comments

@jcrist
Copy link
Member

jcrist commented Jan 24, 2025

Currently most models in cuml match the sklearn interface (or at least are intended to). The exception seems to be the models in cuml.tsa, which match the interface in statsmodels IIUC.

  • Are we ok with different interfaces being implemented in this project (my guess is yes)?
  • If so, should we use a separate base class than cuml.internals.Base for those that don't match the sklearn interface?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcrist