Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: New notebook/demo showcasing spatial relationship predicates #1138

Open
harrism opened this issue May 16, 2023 · 1 comment · Fixed by #1156
Open

[FEA]: New notebook/demo showcasing spatial relationship predicates #1138

harrism opened this issue May 16, 2023 · 1 comment · Fixed by #1156
Assignees
@thomcom
Labels
feature request New feature or request
Milestone
DE-9IM

Comments

@harrism
Copy link
Member

harrism commented May 16, 2023

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

Critical (currently preventing usage)

Please provide a clear description of problem you would like to solve.

With all the new spatial relationship predicates supported in GeoSeries, we should add a new notebook showing them off.

This has been on the roadmap doc for 23.06 for a while, but I couldn't find an issue for it. @thomcom please let me know if this is unrealistic at this point and we can move to 23.08.

Describe any alternatives you have considered

No response

Additional context

No response
@harrism harrism added feature request New feature or request Needs Triage Need team to review and classify labels May 16, 2023
@harrism harrism added this to the DE-9IM milestone May 16, 2023
@thomcom thomcom mentioned this issue May 19, 2023
Closed
@thomcom thomcom moved this from Todo to In Progress in cuSpatial May 22, 2023
@thomcom thomcom mentioned this issue May 26, 2023
Merged
3 tasks
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Jun 5, 2023
@jarmak-nv jarmak-nv moved this from In Progress to Review in cuSpatial Jun 20, 2023
@thomcom thomcom moved this from Review to In Progress in cuSpatial Jun 23, 2023
@rapids-bot rapids-bot bot closed this as completed in #1156 Aug 4, 2023
rapids-bot bot pushed a commit that referenced this issue Aug 4, 2023
@thomcom
Binary Predicates Introduction and Benchmark Notebook (#1156)
ae8eb90 
Closes #1138
Closes #1141 [here](https://github.com/rapidsai/cuspatial/pull/1156/files#diff-c522c9afb3364b1aed2b2589c0d0c260dbc634bc54844536b1d382cecb92bf29R112)
Depends on #1152
Depends on #1064

Please direct your attention [to the notebook](https://github.com/rapidsai/cuspatial/pull/1156/files#diff-cc4c516f63efa822793d75315c1b28a04bad6c9efc6fd2bdcac5cc30b05d14dd) since the dependencies and delayed state of CI issues over this week have put a lot of files into this PR.

This notebook demonstrates cuSpatial's new binary predicates on large datasets, benchmarking and comparing against the host implementation on GeoPandas.

In order to support the large inputs for these comparisons I had to reactivate the `pairwise_point_in_polygon` functionality that I'd previously written off. This is because quadtree doesn't support large N for NxN operations, since it is many-to-many, and brute-force would require a huge number of iterations to support such large dataframes. There are some more optimizations that can be made to speed up `pairwise_point_in_polygon`, but the algorithm itself isn't sufficiently fast. It is detailed fairly closely in the notebook.

Please take a look and let's have some conversations about steps forward.

Authors:
  - H. Thomson Comer (https://github.com/thomcom)

Approvers:
  - Michael Wang (https://github.com/isVoid)
  - Mark Harris (https://github.com/harrism)
  - Ray Douglass (https://github.com/raydouglass)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1156
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuSpatial Aug 4, 2023
@harrism
Copy link
Member Author

harrism commented Aug 15, 2023

I think we should reopen this issue. We have a benchmark notebook, but not a demo / overview notebook for spatial relationship predicates.

@harrism harrism reopened this Aug 15, 2023
@github-project-automation github-project-automation bot moved this from Done to Todo in cuSpatial Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomcom thomcom

Labels
feature request New feature or request
Projects
cuSpatial
Status: Todo
Milestone
DE-9IM
Development

Successfully merging a pull request may close this issue.

Binary Predicates Introduction and Benchmark Notebook thomcom/cuspatial
3 participants
@thomcom @harrism @jarmak-nv