-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Relax requirements for versions.json git_url / git_tag for proprietary binaries #702
Comments
@robertmaynard @KyleFromNVIDIA Could you weigh in on this proposal and/or offer guidance on how to implement it? |
This sounds fine to me. Updating the logic in rapids-cmake with this exception should be pretty straightforward. |
To allow the removal of nvcomp 2.2.0, we make the git tag and repo arguments optional, since all nvcomp versions now use the proprietary binary instead. Fixes: rapidsai#702
The general design across rapids-cmake is to rely on required fields to well exist. Making a required field conditonal based on the existence of another field will require us to change the pinning logic. There is very minimal validation performed on the git_url or git_tag fields. So something like Given that nvcomp is our only |
@robertmaynard Thanks, that's exactly the kind of feedback I was hoping for. I will open an alternative PR with that change. edit: See #704. |
Is your feature request related to a problem? Please describe.
cuDF has not supported nvcomp 2.2.0 for a long time, but rapids-cmake's
versions.json
still has an entry for nvcomp 2.2.0 and the outdated repo page (the nvcomp repo states, "This page will be retired soon" so thegit_url
will soon be irrelevant). However, we can't remove this outdated information because theversions.json
parser expectsgit_url
andgit_tag
to exist.Describe the solution you'd like
Update the parser so that proprietary packages can be used with only
proprietary_binary
information, without specifyinggit_url
andgit_tag
.Describe alternatives you've considered
One alternative would be to allow an empty string like
"git_url": ""
/"git_tag": ""
, but that also fails withrapids_cmake can't parse 'nvcomp' json entry, it is missing a `git_url` entry.
Additional context
Related to rapidsai/cudf#16757.
The text was updated successfully, but these errors were encountered: