Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Conda package for rmm 24.04.00 clobbering files from fmt and spdlog #1528

Open
cryos opened this issue Apr 11, 2024 · 9 comments
Open
Assignees
Labels
bug Something isn't working conda

Comments

@cryos
Copy link

cryos commented Apr 11, 2024

Describe the bug
Looking at librmm-24.04.00-cuda12_240410_g8f19c9c3_0.tar.bz from the rapidsai conda channel I see multiple warnings about clobbered files from fmt and spdlog.

Steps/Code to reproduce bug
I downloaded https://anaconda.org/rapidsai/librmm/24.04.00/download/linux-64/librmm-24.04.00-cuda12_240410_g8f19c9c3_0.tar.bz2 and untarred, I see multiple files that are installed to paths that conflict such as lib/libfmt.a, lib/libspdlog.a, include/fmt/color.h, include/spdlog/common.h that cause conflicts.

Expected behavior
The vendored files should be installed in paths that would not cause conflicts with other packages.

Environment details (please complete the following information):

  • Environment location: [Bare-metal, Docker]
  • Method of RMM install: conda
@cryos cryos added ? - Needs Triage Need team to review and classify bug Something isn't working labels Apr 11, 2024
@bdice
Copy link
Contributor

bdice commented Apr 13, 2024

Thanks for filing this. We've been working on improving this systemically across RAPIDS, because this kind of issue pops up in several places. PR #1508 will help us identify issues like this and prevent them going forward. @AyodeAwe @jameslamb If you're able to collaborate on this effort, it would be a great help. I know both of you have expressed interest in this before. Also #1307 is relevant to this for CCCL (another set of headers that are clobbered by a few RAPIDS packages).

@bdice bdice removed the ? - Needs Triage Need team to review and classify label Apr 13, 2024
@jameslamb
Copy link
Member

jameslamb commented Apr 19, 2024

Thanks for the @! Linked to this on #1508, we're working on this there.

@harrism harrism added the conda label Apr 22, 2024
@harrism harrism moved this from Todo to In Progress in RMM Project Board Apr 22, 2024
@harrism
Copy link
Member

harrism commented Apr 22, 2024

I see that #1508 "contributes to" fixing this issue. What is needed to fully fix it?

@jameslamb
Copy link
Member

What is needed to fully fix it?

I'm still investigating that. By the time I move #1508 out of draft and put it up for review, hopefully we'll be able to change "contributes" to "fixes". Will post updates there as I go.

@jameslamb
Copy link
Member

Oh, I just realized it isn't currently in draft. That's an oversight... I just moved it there.

@harrism
Copy link
Member

harrism commented Jul 22, 2024

Subscribe to rapidsai/build-planning#54 and rapidsai/build-planning#56 for updates.

@wence-
Copy link
Contributor

wence- commented Sep 24, 2024

@jameslamb with rapidsai/rapids-cmake#689 and the RMM changes in #1678 is this one now resolved?

@jameslamb
Copy link
Member

@wence- no, this issue won't be resolved in 24.10.

We ended up needing to take a patch on fmt in rapids-cmake (rapidsai/rapids-cmake#689 (comment)), which means it's getting downloaded with CPM, which means it's getting vendored in rmm packages, which means there will still be clobbering issues related to fmt.

@wence-
Copy link
Contributor

wence- commented Sep 24, 2024

Thanks for the update, I'll move to 24.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

5 participants