Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Allow RMM_DEFAULT_HOST_ALIGNMENT alignment in pool_memory_resource #1585

Open
PointKernel opened this issue Jun 13, 2024 · 1 comment
Labels
feature request New feature or request wontfix This will not be worked on

Comments

@PointKernel
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently, the alignment check in pool_memory_resource ctor is hardcoded to check against CUDA_ALLOCATION_ALIGNMENT:

RMM_EXPECTS(rmm::is_aligned(initial_pool_size, rmm::CUDA_ALLOCATION_ALIGNMENT),
"Error, Initial pool size required to be a multiple of 256 bytes");
RMM_EXPECTS(rmm::is_aligned(maximum_pool_size.value_or(0), rmm::CUDA_ALLOCATION_ALIGNMENT),
"Error, Maximum pool size required to be a multiple of 256 bytes");

This causes problems for host memory pools.

Additional context
Related issue: rapidsai/cudf#16024

@PointKernel PointKernel added ? - Needs Triage Need team to review and classify feature request New feature or request labels Jun 13, 2024
@harrism
Copy link
Member

harrism commented Jun 18, 2024

I discussed this internally at NVIDIA, and the current recommendation for anything device-accessible is to leave the required alignment at rmm::CUDA_ALLOCATION_ALIGNMENT, and not relax it to DEFAULT_HOST_ALIGNMENT. I'll leave this issue open for discussion for now.

@harrism harrism added wontfix This will not be worked on and removed ? - Needs Triage Need team to review and classify labels Jun 18, 2024
@harrism harrism moved this from Todo to Blocked in RMM Project Board Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request wontfix This will not be worked on
Projects
Status: Blocked
Development

No branches or pull requests

2 participants