extractWithoutRootDirectory() fails if destination is .

[xabbuh]

If you pass . (the current working directory) as the destination to the Distill::extractWithoutRootDirectory() method, extracting the archive fails with a message like this:

rmdir: failed to remove ‘.’: Invalid argument

The reason for this is, for example, explained here.

[raulfraile]

@xabbuh thanks for opening the issue! Working on it...

[xabbuh]

@raulfraile Thank you. I thought that calling realpath() on the path that is passed to rmdir() would suffice. However, that led to other issues (probably due to the fact that the current working directory does not exist any more after the removal). Maybe we need to switch the working directory first in those cases.

[raulfraile]

@xabbuh yes, I'm working with that approach, the working directory needs to be changed first

[raulfraile]

@xabbuh it should be fixed in the fix/current_dir branch. Do you have any comments about eb8fed8?

[xabbuh]

@raulfraile Do we need some special handling in case there is no parent directory?

[raulfraile]

@xabbuh would that happen only if you are in the root directory or is there any other situation? Anyway, I think we should handle gracefully and throw an error

[xabbuh]

I think this will only happen when you are in the root directory.

[xabbuh]

@raulfraile The fix does not work as is. I think the issue is the check if ('.' === $path). Imho this needs to be either if ('.' === basename($path) or something like if (getcwd() === realpath($path)).

[raulfraile]

@xabbuh thanks for your suggestions! Now I throw an exception when you are in the root directory and I use getcwd() === realpath($path) to check if the target directory is the same as the current directory

[raulfraile]

Commit: 5fa7ce1

[xabbuh]

@raulfraile I can confirm that this fixes the root issue.

[xabbuh]

@raulfraile I see one issue with the proposed solution: When using the Symfony installer, the user would have to change directories after installing Symfony in the current directory because the current working directory does not exist anymore. What do you think about extracting the archive to a temporary subdirectory instead and moving contents up after the extraction succeeded?