Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation for skew fields, and fields which don't close under all implemented operations #10

Open
duetosymmetry opened this issue Dec 13, 2017 · 1 comment

Comments

@duetosymmetry
Copy link
Contributor

  1. If we are working in the quaternions ℍ, there are two canonical forms for a polynomial; we could either use the left or right polynomial, i.e. P(x) = ∑ a_k x^k, or P(x) = ∑ x^k b_k. These two differ because ℍ is non-commutative. This subtlety needs to be documented, and ensured that it's implemented consistently throughout, e.g. within toString, toHorner, mul, and eval.
  2. The fields ℚ and ℝ are not closed under the pow operation, but this operation is assumed to be implemented for each field. This needs to be documented.
@infusion
Copy link
Collaborator

infusion commented Feb 15, 2018

You are totally right on both points. Did you encounter a problem in the code with respect to non-commutativity or is it just a documentation thing?
When I implemented the lib back then, I saw the problem of this and decided to go with integer exponents only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants