Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace subscriptions-transport-ws with graphql-ws #1358

Open
carrolp opened this issue Apr 24, 2024 · 0 comments
Open

Replace subscriptions-transport-ws with graphql-ws #1358

carrolp opened this issue Apr 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@carrolp
Copy link
Contributor

carrolp commented Apr 24, 2024

The subscriptions-transport-ws dependency is deprecated and the readme recommends switching to graphql-ws: https://www.npmjs.com/package/subscriptions-transport-ws

However, as noted in https://www.apollographql.com/docs/apollo-server/data/subscriptions/#switching-from-subscriptions-transport-ws:

If you use subscriptions with Apollo Client you must ensure both your client and server subscription protocols are consistent for the subscription library you're using.

I.e. the Razeedash-api server and ClusterSubscription client must be using the same library. To transition to graphql-ws will likely require updating ClusterSubscription to tolerate websocket failure and instead rely on polling until the server is updated later, after a period of transition.

@carrolp carrolp added the enhancement New feature or request label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant