-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semantic_version.match emits a PendingDeprecationWarning #147
Comments
OpenBagTwo
added a commit
to OpenBagTwo/EnderChest
that referenced
this issue
May 17, 2023
rbarrois/python-semanticversion#147 notwithstanding
Ah. Looks like this is related to #109. Feel free to close this as a dupe (though please let me know first if the top-level |
OpenBagTwo
added a commit
to OpenBagTwo/EnderChest
that referenced
this issue
May 17, 2023
rbarrois/python-semanticversion#147 notwithstanding This commit implements #27
OpenBagTwo
added a commit
to OpenBagTwo/EnderChest
that referenced
this issue
May 23, 2023
rbarrois/python-semanticversion#147 notwithstanding This commit implements #27
OpenBagTwo
added a commit
to OpenBagTwo/EnderChest
that referenced
this issue
May 31, 2023
rbarrois/python-semanticversion#147 notwithstanding This commit implements #27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Calling the top-level
match
method emits aPendingDeprecationWarning
regardless of the provided inputsEnvironment and Version
semantic_version
version: '2.10.0'Steps to Reproduce
produces:
Workaround
Being hyper-explicit in my call:
will produce the desired result with no warning
Severity
Annoyance. I'm using this as a dependency in a personal project, and the deprecation shows up all over my test logs. Given that the API seems to be somewhat in flux, I'd prefer to rely on the simple string-matching method, unless that too is deprecated.
Desired Outcome
Looking at the current implementation:
python-semanticversion/semantic_version/base.py
Lines 606 to 607 in 2cbbee3
It seems like it would be a simple matter of changing:
but if the intent is to wean users off of the direct
match
method, then the current behavior makes sense.The text was updated successfully, but these errors were encountered: