Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI change - error rendering in Visit form #123

Closed
4 tasks done
dc2007git opened this issue Jun 13, 2024 · 2 comments · Fixed by #131
Closed
4 tasks done

UI change - error rendering in Visit form #123

dc2007git opened this issue Jun 13, 2024 · 2 comments · Fixed by #131
Labels
bug Something isn't working enhancement New feature or request user interface Improvements or fixes here mainly to the user interface

Comments

@dc2007git
Copy link
Contributor

dc2007git commented Jun 13, 2024

[after dev team discussion]

  • 1. When a user is looking at the Visit List view for a patient, it is clear where the errors are, and hovering over the red tabs for the erroneous categories shows the error message. Persisting these error messages somewhere into the form would be very helpful for the user to know what is wrong with the current state of the visit.

  • 2. The errors do present themselves, but only on form submission. So if the user goes onto the form, the error messages are not present, and they would have to submit the erroneous form again for the errors to pop up.

  • 3. When the errors do pop up as described in point 2, they are not formatted well. Tidying them up to make them inline would be nicer.

  • 4. Additionally, it isn't [totally] obvious that there are tooltips over the errors which contain the exact error messages. It might be nice to have a 'Hover for Error message' text in the column header:

image
@dc2007git dc2007git added bug Something isn't working enhancement New feature or request user interface Improvements or fixes here mainly to the user interface labels Jun 13, 2024
@dc2007git
Copy link
Contributor Author

Additionally:
image

In this visit, routine measurements does have errors, but because it is the selected tab, it turns pink for some reason. Also needs fixing

@dc2007git dc2007git linked a pull request Jun 17, 2024 that will close this issue
@dc2007git dc2007git reopened this Jun 24, 2024
@eatyourpeas
Copy link
Member

now fixed with #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request user interface Improvements or fixes here mainly to the user interface
Projects
None yet
2 participants