Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CSV upload missing headers #348

Closed
mbarton opened this issue Nov 1, 2024 · 2 comments · Fixed by #326
Closed

Handle CSV upload missing headers #348

mbarton opened this issue Nov 1, 2024 · 2 comments · Fixed by #326

Comments

@mbarton
Copy link
Member

mbarton commented Nov 1, 2024

Some users upload CSV files without headers. We would have to assume they're following the template and parse accordingly

@AmaniKrayemRCPCH to confirm how many users do this

@eatyourpeas
Copy link
Member

That feels to me a bit too permissive. I don't think it is too much to ask for clinicians/admin to provide the data in the requested format. We are stripping spaces etc if the headings have these sorts of invisible errors but the documentation for submission is good and has been in place a long time.
My vote is to reject the whole csv at the point of upload if the basic data types are not correct with a polite message to check their working and try again. This would include providing the header names in the requested format, given that if the data are provided with the columns in a different order, without the column headings, we would have no idea which column was which.

@eatyourpeas
Copy link
Member

I have implemented this btw in #368 but very simple to undo if people prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants