Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid looping forever if core pinning fails #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IagoAbal
Copy link

@IagoAbal IagoAbal commented Jul 5, 2021

This is known to happen, under some circumstances, on Apple M1.

Plus code cleanup.

Closes #103

This is known to happen, under some circumstances, on Apple M1.

Plus code cleanup.

Closes rdicosmo#103
@IagoAbal
Copy link
Author

IagoAbal commented Jul 5, 2021

Be aware that I have not done extensive testing of these changes! For now I have jut ran make test on an Apple M1. I will try to do the same from a Linux machine.

@rdicosmo
Copy link
Owner

Thanks for looking into this. It is difficult to follow the diff you proposed, though: there is code that is moved untouched in a separate subroutine, and it is not clear what the proposed change really is.
May you submit a separate PR with only the change in the logic, without the code reshuffling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop if core pinning fails
2 participants