Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Rewrite ARTSerializablePath to use class #6

Open
Esemesek opened this issue Jun 15, 2019 · 1 comment
Open

Rewrite ARTSerializablePath to use class #6

Esemesek opened this issue Jun 15, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Esemesek
Copy link
Collaborator

ARTSerializablePath.js is written using legacy helper from art/core/class. We should refactor it to use ES6 class syntax.

class ARTSerializablePath {
	...
}
@Esemesek Esemesek added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 15, 2019
@thymikee
Copy link

If anyone's interested, I started the work on https://github.com/react-native-community/art/tree/chore/path-as-class branch, but I'm likely not gonna continue and I'm also not convinced this is cleaner approach :D We'll need to override typings anyway, since art/core/path is untyped.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants