You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
I believe art is not autolinking as expected in 0.62. Related: #54
even after having art in my node_modules and in package json, pod install output doesn't show art as auto-detected:
$ cd ./ios && pod install --repo-update && cd ..
Detected React Native module pods for A0Auth0, RNAWSCognito, RNCAsyncStorage, RNCMaskedView, RNDateTimePicker, RNGestureHandler, RNIap, RNImageCropPicker, RNReanimated, RNSVG, RNScreens, RNSound, react-native-branch, react-native-fbsdk, react-native-geolocation, react-native-netinfo, react-native-onesignal, react-native-safe-area-context, react-native-version-number, react-native-viewpager, and rn-fetch-blob
(expected to see art above)
as I posted on 54, adding to podfile directly fixes.
art 1.2.0, rn 0.62.2
Environment info
react-native info output:
info Fetching system and libraries information...
System:
OS: macOS Mojave 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz
Memory: 238.36 MB / 16.00 GB
Shell: 5.0.16 - /usr/local/bin/bash
Binaries:
Node: 13.12.0 - ~/.nvm/versions/node/v13.12.0/bin/node
Yarn: 1.22.4 - /usr/local/bin/yarn
npm: 6.14.4 - ~/.nvm/versions/node/v13.12.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 21, 22, 24, 25, 26, 27, 28
Build Tools: 23.0.1, 23.0.2, 26.0.1, 26.0.2, 26.0.3, 27.0.2, 27.0.3, 28.0.0, 28.0.3, 29.0.0, 29.0.1
System Images: android-21 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5522156
Xcode: 11.3.1/11C504 - /usr/bin/xcodebuild
Languages:
Java: 1.8.0_202-ea - /usr/bin/javac
Python: 2.7.17 - /usr/local/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.62.2 => 0.62.2
npmGlobalPackages:
*react-native*: Not Found
Library version: 1.2.0
Steps To Reproduce
react-native init 0.62.2 repo
add art as dep
import some shapes, surface etc...
build project (notice pod install output)
expect crash on "native module not found" type error
...
Describe what you expected to happen:
no crash, auto link succeeds
Reproducible sample code
podfile
platform:ios,'9.0'require_relative'../node_modules/@react-native-community/cli-platform-ios/native_modules'defadd_flipper_pods!(versions={})versions['Flipper'] ||= '~> 0.33.1'versions['DoubleConversion'] ||= '1.1.7'versions['Flipper-Folly'] ||= '~> 2.1'versions['Flipper-Glog'] ||= '0.3.6'versions['Flipper-PeerTalk'] ||= '~> 0.0.4'versions['Flipper-RSocket'] ||= '~> 1.0'pod'FlipperKit',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FlipperKitLayoutPlugin',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/SKIOSNetworkPlugin',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FlipperKitUserDefaultsPlugin',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FlipperKitReactPlugin',versions['Flipper'],:configuration=>'Debug'# List all transitive dependencies for FlipperKit pods# to avoid them being linked in Release buildspod'Flipper',versions['Flipper'],:configuration=>'Debug'pod'Flipper-DoubleConversion',versions['DoubleConversion'],:configuration=>'Debug'pod'Flipper-Folly',versions['Flipper-Folly'],:configuration=>'Debug'pod'Flipper-Glog',versions['Flipper-Glog'],:configuration=>'Debug'pod'Flipper-PeerTalk',versions['Flipper-PeerTalk'],:configuration=>'Debug'pod'Flipper-RSocket',versions['Flipper-RSocket'],:configuration=>'Debug'pod'FlipperKit/Core',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/CppBridge',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FBCxxFollyDynamicConvert',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FBDefines',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FKPortForwarding',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FlipperKitHighlightOverlay',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FlipperKitLayoutTextSearchable',versions['Flipper'],:configuration=>'Debug'pod'FlipperKit/FlipperKitNetworkPlugin',versions['Flipper'],:configuration=>'Debug'end# Post Install processing for Flipperdefflipper_post_install(installer)installer.pods_project.targets.eachdo |target|
iftarget.name == 'YogaKit'target.build_configurations.eachdo |config|
config.build_settings['SWIFT_VERSION']='5.0'endendend# This post_install hook adds the -DFB_SONARKIT_ENABLED=1 flag to OTHER_CFLAGS, necessary to expose Flipper classes in the header filesfile_name=Dir.glob("*.xcodeproj")[0]app_project=Xcodeproj::Project.open(file_name)app_project.native_targets.eachdo |target|
target.build_configurations.eachdo |config|
cflags=config.build_settings['OTHER_CFLAGS'] || '$(inherited) 'unlesscflags.include?'-DFB_SONARKIT_ENABLED=1'puts'Adding -DFB_SONARKIT_ENABLED=1 in OTHER_CFLAGS...'cflags << '-DFB_SONARKIT_ENABLED=1'endconfig.build_settings['OTHER_CFLAGS']=cflagsendapp_project.saveendinstaller.pods_project.saveendtarget'App'do# Pods for Apppod'FBLazyVector',:path=>"../node_modules/react-native/Libraries/FBLazyVector"pod'FBReactNativeSpec',:path=>"../node_modules/react-native/Libraries/FBReactNativeSpec"pod'RCTRequired',:path=>"../node_modules/react-native/Libraries/RCTRequired"pod'RCTTypeSafety',:path=>"../node_modules/react-native/Libraries/TypeSafety"pod'React',:path=>'../node_modules/react-native/'pod'React-Core',:path=>'../node_modules/react-native/'pod'React-CoreModules',:path=>'../node_modules/react-native/React/CoreModules'pod'React-Core/DevSupport',:path=>'../node_modules/react-native/'pod'React-RCTActionSheet',:path=>'../node_modules/react-native/Libraries/ActionSheetIOS'pod'React-RCTAnimation',:path=>'../node_modules/react-native/Libraries/NativeAnimation'pod'React-RCTBlob',:path=>'../node_modules/react-native/Libraries/Blob'pod'React-RCTImage',:path=>'../node_modules/react-native/Libraries/Image'pod'React-RCTLinking',:path=>'../node_modules/react-native/Libraries/LinkingIOS'pod'React-RCTNetwork',:path=>'../node_modules/react-native/Libraries/Network'pod'React-RCTSettings',:path=>'../node_modules/react-native/Libraries/Settings'pod'React-RCTText',:path=>'../node_modules/react-native/Libraries/Text'pod'React-RCTVibration',:path=>'../node_modules/react-native/Libraries/Vibration'pod'React-Core/RCTWebSocket',:path=>'../node_modules/react-native/'pod'ReactNativeART',:path=>'../node_modules/@react-native-community/art'pod'React-cxxreact',:path=>'../node_modules/react-native/ReactCommon/cxxreact'pod'React-jsi',:path=>'../node_modules/react-native/ReactCommon/jsi'pod'React-jsiexecutor',:path=>'../node_modules/react-native/ReactCommon/jsiexecutor'pod'React-jsinspector',:path=>'../node_modules/react-native/ReactCommon/jsinspector'pod'ReactCommon/callinvoker',:path=>"../node_modules/react-native/ReactCommon"pod'ReactCommon/turbomodule/core',:path=>"../node_modules/react-native/ReactCommon"pod'Yoga',:path=>'../node_modules/react-native/ReactCommon/yoga',:modular_headers=>truepod'DoubleConversion',:podspec=>'../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'pod'glog',:podspec=>'../node_modules/react-native/third-party-podspecs/glog.podspec'pod'Folly',:podspec=>'../node_modules/react-native/third-party-podspecs/Folly.podspec'target'AppTests'doinherit!:complete# Pods for testingenduse_native_modules!# Enables Flipper.## Note that if you have use_frameworks! enabled, Flipper will not work and# you should disable these next few lines.add_flipper_pods!post_installdo |installer|
flipper_post_install(installer)endendtarget'App-tvOS'do# Pods for App-tvOStarget'App-tvOSTests'doinherit!:search_paths# Pods for testingendtarget'OneSignalNotificationServiceExtension'dopod'OneSignal','>= 2.9.3','< 3.0'endend
The text was updated successfully, but these errors were encountered:
Bug
I believe art is not autolinking as expected in 0.62. Related: #54
even after having art in my node_modules and in package json,
pod install
output doesn't show art as auto-detected:(expected to see art above)
as I posted on 54, adding to podfile directly fixes.
art 1.2.0, rn 0.62.2
Environment info
react-native info
output:Library version: 1.2.0
Steps To Reproduce
...
Describe what you expected to happen:
Reproducible sample code
podfile
The text was updated successfully, but these errors were encountered: