-
Notifications
You must be signed in to change notification settings - Fork 404
Upcoming v0.63.3 cherrypicks discussion #203
Comments
(I am always scared I will skip one minor version) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@nhuson269 @1awaleed this issue is only for commits to cherry pick |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@grabbou it seems like we need to fix this asap |
This comment has been minimized.
This comment has been minimized.
@TheSavior Can we get this merged so we can pick it here? facebook/react-native#29074. Landed commit facebook/react-native@dc2df75 |
This comment has been minimized.
This comment has been minimized.
@grabbou could I please get facebook/react-native@ffc90c7 picked ? it resolves facebook/react-native#29364 is there any other information I need to provide? Thank you |
This comment has been minimized.
This comment has been minimized.
Please get both of these released in tandem! |
I think if this really solves the issue for iOS, it would be nice to have! 👍 for this one! |
Image api |
friendly reminder folks: it's August. Expect things to slow down. There are currently only 3 commits requested that are cherry pickable: The rest of the links are not actionables currently (one is an open PR and the other requires an Hermes releases AFAIK so not doable for a patch release). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hey folks, currently no updates. We are still waiting on facebook/react-native#29477 to be merged since that should also be related to helping us move closer to be able to cut 0.64. What is likely to happen is 0.64rc0 first, then probably 0.63.3 (unless upgrading to 0.64 looks trivial in which case we'll focus on getting to 0.64.0 directly). Sorry for the delays, summer/end of summer are always complicated. |
Can we merge facebook/react-native@86ffb9c for facebook/react-native#29376? |
Can we cherrypick facebook/react-native@d8b70b1 and make sure #203 (comment) as well makes it in. issue: facebook/react-native#29364 Both resolves image issues on Android & iOS that has had 100+ comments on each of their issues. |
Can we cherry-pick facebook/react-native@45954ac? |
While not yet merged, I expect it to be merged soon. facebook/react-native#29995 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @kelset; looks like facebook/react-native#29477 is merged. Any updates on release? Would be great to have that bundler working in staging and release again 😅 |
@kelset is currently on vacation, so I’ll try to find some time later this week or Monday to cut a release. |
This comment has been minimized.
This comment has been minimized.
@a-eid As per the OP, this issue is only to discuss cherry-picking fixes that have landed in the |
Let's try to sum up the current status of things: Commits requested related to fixes:
This commit facebook/react-native@d8b70b1 has been requested but since it changes the version of Flipper, I have reservations of making this happen in a patch release, but happy to consider it if it's that important. Aside from the above, there are 2 more things to keep an eye on:
|
@kelset would be nice to have this as well: |
@kelset thanks for the update! didn't realize facebook/react-native#29477 was merged so shortly before my comment 😅. I stumbled across that PR while in the midst of a furious debugging session , then saw this thread, and figured I'd bump, without seeing the timeline. Thanks again for your responsiveness! |
Is it too late to add a commit for this version? Fixes the iOS Gif not animating when TurboModule is enabled: facebook/react-native@663b5a8. |
This comment has been minimized.
This comment has been minimized.
Here's the list of commits we'll attempt to cherry pick for 0.63.3, in chrono order (oldest -> newest):
In the changelog we should also still mention/redirect people to this issue facebook/react-native#29984 in case they have problems with Xcode12 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Status of branch after cherry picking; final list of commits cherry picked:
We will now do some testing both locally and on CI and see if everything goes well. If that's the case, we will proceed with the release. UPDATE: looks like between the last time I did a release and now someone downgraded my permissions so I can't push to the 0.63 branch... so yeah currently stuck. Either another maintainer will jump in and repeat what I've just done or my auth will be restored. Will let you know once I have updates. UPDATE 2: looks like my permissions issue will be fixed, but no ETA for it so it's likely that another maintainer will do the cherry picking stuff. UPDATE 3: permissions have been fixed, I've redone the cherry picking phase to accomodate for Brent's commit (since it's the oldest) and while doing so I've re done the conflicts resolutions in a way that I'm more confident is correct. I've pushed the commits to the remote branch now so that we can have CI tests and other maintainers can also locally do the E2E testing. UPDATE 4: note to self, we may have to add this facebook/react-native@001eb7c |
this may be worth cherry picking as well: facebook/react-native@43c161c it fixes facebook/react-native#29360 |
Allright folks, after all that rollercoaster we finally managed to push through and release 0.63.3! (thanks to @alloy for all the support!) It's been a wild ride, hopefully now we can focus on getting the final touches ready cutting the 0.64 branch - in case something wild happen, please refer to the new issue: #212 |
Conversations on this thread are limited to 0.63 releases major issues and backport (cherry-pick) requests from commits that are already on master.
An example of a good such request is a bug fix for a serious issue that has been merged into master but did not make the 0.63.2 cut.
In other words, if you cannot point to a particular commit on master, then your request likely belongs as a new issue in http://github.com/facebook/react-native/issues.
The text was updated successfully, but these errors were encountered: