Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useMergedRef not being exported by index #10

Open
bpas247 opened this issue Aug 9, 2019 · 5 comments
Open

useMergedRef not being exported by index #10

bpas247 opened this issue Aug 9, 2019 · 5 comments

Comments

@bpas247
Copy link

bpas247 commented Aug 9, 2019

Probably just a missed step in #9, but we should export the useMergedRef hook from src/index.ts.
@Shadowlauch
Copy link

The FocusManager is also not reexported

@taion
Copy link
Member

taion commented Nov 22, 2019

Actually, a ton of stuff isn't. Should they be?

@jquense
Copy link
Member

jquense commented Nov 22, 2019

probably, but i don't think about it since we cherry-pick

@taion
Copy link
Member

taion commented Nov 22, 2019

Should we get rid of index then?

@Shadowlauch
Copy link

Getting rid of the index would introduce a breaking change though. I personally quite like the named exports from an index and with proper tree shaking it does not introduce unnessecary code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jquense @Shadowlauch @taion @bpas247