From 6de1dbb90b052fcac63643b33637491b359ca3a3 Mon Sep 17 00:00:00 2001
From: Tim M <49349513+TimothyMakkison@users.noreply.github.com>
Date: Sat, 26 Oct 2024 03:00:43 +0100
Subject: [PATCH] feat: change `IPerformanceService` to return
 `HttpResponseMessage` (#1893)

---
 Refit.Benchmarks/IPerformanceService.cs  | 10 +++++-----
 Refit.Benchmarks/PerformanceBenchmark.cs | 10 +++++-----
 Refit.Benchmarks/StartupBenchmark.cs     |  8 ++++----
 3 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/Refit.Benchmarks/IPerformanceService.cs b/Refit.Benchmarks/IPerformanceService.cs
index 36b7036a8..d01358d45 100644
--- a/Refit.Benchmarks/IPerformanceService.cs
+++ b/Refit.Benchmarks/IPerformanceService.cs
@@ -3,20 +3,20 @@
 public interface IPerformanceService
 {
     [Get("/users")]
-    public Task<string> ConstantRoute();
+    public Task<HttpResponseMessage> ConstantRoute();
 
     [Get("/users/{id}")]
-    public Task<string> DynamicRoute(int id);
+    public Task<HttpResponseMessage> DynamicRoute(int id);
 
     [Get("/users/{id}/{user}/{status}")]
-    public Task<string> ComplexDynamicRoute(int id, string user, string status);
+    public Task<HttpResponseMessage> ComplexDynamicRoute(int id, string user, string status);
 
     [Get("/users/{request.someProperty}")]
-    public Task<string> ObjectRequest(PathBoundObject request);
+    public Task<HttpResponseMessage> ObjectRequest(PathBoundObject request);
 
     [Post("/users/{id}/{request.someProperty}")]
     [Headers("User-Agent: Awesome Octocat App", "X-Emoji: :smile_cat:")]
-    public Task<string> ComplexRequest(int id, PathBoundObject request, [Query(CollectionFormat.Multi)]int[] queries);
+    public Task<HttpResponseMessage> ComplexRequest(int id, PathBoundObject request, [Query(CollectionFormat.Multi)]int[] queries);
 }
 
 public class PathBoundObject
diff --git a/Refit.Benchmarks/PerformanceBenchmark.cs b/Refit.Benchmarks/PerformanceBenchmark.cs
index d34d912bb..8a1b09678 100644
--- a/Refit.Benchmarks/PerformanceBenchmark.cs
+++ b/Refit.Benchmarks/PerformanceBenchmark.cs
@@ -32,17 +32,17 @@ public Task SetupAsync()
     }
 
     [Benchmark]
-    public async Task<string> ConstantRouteAsync() => await service.ConstantRoute();
+    public async Task<HttpResponseMessage> ConstantRouteAsync() => await service.ConstantRoute();
 
     [Benchmark]
-    public async Task<string> DynamicRouteAsync() => await service.DynamicRoute(101);
+    public async Task<HttpResponseMessage> DynamicRouteAsync() => await service.DynamicRoute(101);
 
     [Benchmark]
-    public async Task<string> ComplexDynamicRouteAsync() => await service.ComplexDynamicRoute(101, "tom", "yCxv");
+    public async Task<HttpResponseMessage> ComplexDynamicRouteAsync() => await service.ComplexDynamicRoute(101, "tom", "yCxv");
 
     [Benchmark]
-    public async Task<string> ObjectRequestAsync() => await service.ObjectRequest(new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"});
+    public async Task<HttpResponseMessage> ObjectRequestAsync() => await service.ObjectRequest(new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"});
 
     [Benchmark]
-    public async Task<string> ComplexRequestAsync() => await service.ComplexRequest(101, new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"}, [1,2,3,4,5,6]);
+    public async Task<HttpResponseMessage> ComplexRequestAsync() => await service.ComplexRequest(101, new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"}, [1,2,3,4,5,6]);
 }
diff --git a/Refit.Benchmarks/StartupBenchmark.cs b/Refit.Benchmarks/StartupBenchmark.cs
index babd94bb2..e1e2fdee4 100644
--- a/Refit.Benchmarks/StartupBenchmark.cs
+++ b/Refit.Benchmarks/StartupBenchmark.cs
@@ -28,20 +28,20 @@ public void Setup()
     public IPerformanceService CreateService() => RestService.For<IPerformanceService>(Host, settings);
 
     [Benchmark]
-    public async Task<string> FirstCallConstantRouteAsync() => await initialisedService.ConstantRoute();
+    public async Task<HttpResponseMessage> FirstCallConstantRouteAsync() => await initialisedService.ConstantRoute();
 
     [Benchmark]
-    public async Task<string> ConstantRouteAsync()
+    public async Task<HttpResponseMessage> ConstantRouteAsync()
     {
         var service = RestService.For<IPerformanceService>(Host, settings);
         return await service.ConstantRoute();
     }
 
     [Benchmark]
-    public async Task<string> FirstCallComplexRequestAsync() => await initialisedService.ObjectRequest(new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"});
+    public async Task<HttpResponseMessage> FirstCallComplexRequestAsync() => await initialisedService.ObjectRequest(new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"});
 
     [Benchmark]
-    public async Task<string> ComplexRequestAsync()
+    public async Task<HttpResponseMessage> ComplexRequestAsync()
     {
         var service = RestService.For<IPerformanceService>(Host, settings);
         return await service.ObjectRequest(new PathBoundObject(){SomeProperty = "myProperty", SomeQuery = "myQuery"});