You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have tried other servers (URLs) as well, and for some of them I get a response immediatelly, for some there is a 10s delay. Maybe the socket isn't being closed when using EmptyBodyStream?
The full example (reason I care) is that I though this would work as a simple HTTP proxy:
I talked with @clue about this, and it indeed seems to be a bug that has found its way into the project over the last few releases. We've already started working on a fix for this, so I will keep you updated as we make progress.
As you also may know, we're currently working on ReactPHP v3 and releasing the roadmap tickets for each component (see reactphp/event-loop#271 and others). The HTTP roadmap ticket will also be released soon, and to give you a sneak peek, we plan to release at least v1.10.0 before branching out with a 3.x branch. So, I think it makes sense to resolve this bug as part of the upcoming v1.1.0.0 and thus also for the upcoming v3.
@martin-heralecky Again thank you for reporting, that was a nasty one! I've just filed #516 which fixes the problem and introduces additional tests to avoid any future regressions.
I've double-checked your gist, and I'm happy to confirm that it now works flawlessly with the applied changes. The fix may actually look surprisingly simple, but analyzing the problem and coming up with this fix took a couple of hours. If you'd like to support this development, consider sponsoring ReactPHP! ❤️ Thank you!
There seems to be a problem when attempting to pass
EmptyBodyStream
as body to HTTP requests:Whereas, empty resource works just fine:
I have tried other servers (URLs) as well, and for some of them I get a response immediatelly, for some there is a 10s delay. Maybe the socket isn't being closed when using
EmptyBodyStream
?The full example (reason I care) is that I though this would work as a simple HTTP proxy:
But it only works for requests with non-empty bodies. Otherwise
$req->getBody()
isEmptyBodyStream
and the requests get stuck.The text was updated successfully, but these errors were encountered: