Design Discussion

[hasnainmakada-99]

hello @nirmalkc , I want to discuss regarding the design which we will implement in 43

[atapas]

@hasnainmakada-99 I suggest you develop the component that shows the message of "No Play Found" and complete the logic of showing it conditionally. Once the functionality is done, @nirmalkc will style that component. Just notify here. Thanks!

[atapas]

Put your changes in PR so that I can see code changes. Let's discuss on PR.

[hasnainmakada-99]

Ok sir

[atapas]

@hasnainmakada-99 The fix should be only in one file PlayList.jsx

Please check for the plays array to be null/undefined/empty and call your component to show the message conditionally.

<>
      <ol className="list-plays">
        {plays.map((play, index) => (
          <PlayThumbnail key={play.id} play={play} />
        ))}
      </ol>
    </>

Please raise the PR.

[hasnainmakada-99]

Ok sir ill raise the pr

[hasnainmakada-99]

tapas sir, I've raised the pr please review it, and the functionality is still not working i've tested it with various conditions

[hasnainmakada-99]

@atapas sir now i will have to work only on the playlist.jsx file no ??

[hasnainmakada-99]

[hasnainmakada-99]

here is the working functionality

[atapas]

Cool, open a PR

[hasnainmakada-99]

sir the desgin will noew be reamaining

[hasnainmakada-99]

@atapas sir please review my pr

[ali0sam]

hi, it's not nice to we have a dark background color for /plays ? or just a theme changer button?

[atapas]

@ali0sam I think it should be take as part of theming. Thanks for the callout. I'll create an issue for theme support.