diff --git a/artio-codecs/src/test/java/uk/co/real_logic/artio/util/TestMessages.java b/artio-codecs/src/test/java/uk/co/real_logic/artio/util/TestMessages.java index 17c8a9df2e..98cdb0f340 100644 --- a/artio-codecs/src/test/java/uk/co/real_logic/artio/util/TestMessages.java +++ b/artio-codecs/src/test/java/uk/co/real_logic/artio/util/TestMessages.java @@ -22,8 +22,8 @@ public final class TestMessages { // BUY 100 CVS MKT DAY public static final byte[] EG_MESSAGE = toAscii("8=FIX.4.2\0019=146\00135=D\00134=4\00149=ABC_DEFG01\001" + - "52=20090323-15:40:29\00156=CCG\001115=XYZ\00111=NF 0542/03232009\00154=1\00138=100\00155=CVS\00140=1" + - "\00159=0\00147=A\00160=20090323-15:40:29\00121=1\001207=N\00110=195\001"); + "52=20090323-15:40:29\00156=CCG\001115=XYZ\00111=NF 0542/03232009\00154=1\00138=100\00155=CVS\00140=1" + + "\00159=0\00147=A\00160=20090323-15:40:29\00121=1\001207=N\00110=195\001"); public static final byte[] LOGON_MESSAGE = toAscii("8=FIX.4.2\0019=64\00135=A\00134=1\00149=ABC_DEFG01" + "\00152=20090323-15:40:29\00156=CCG\00198=0\001108=30\00110=161\001"); @@ -36,55 +36,55 @@ public final class TestMessages "\00159=0\00147=A\00160=20090323-15:40:29\00121=1\001207=N\00110=146\001"); public static final byte[] INVALID_CHECKSUM_MSG = toAscii("8=FIX.4.2\0019=133\00135=D\00134=4\00149=ABC_DEFG01\001" + - "52=20090323-15:40:29\00156=CCG\001115=XYZ\00111=NF 0542/03232009\00155=CVS\00140=1\00159=0\00147=A" + - "60=20090323-15:40:29\00121=1\001207=N\00110=155\001"); + "52=20090323-15:40:29\00156=CCG\001115=XYZ\00111=NF 0542/03232009\00155=CVS\00140=1\00159=0\00147=A" + + "60=20090323-15:40:29\00121=1\001207=N\00110=155\001"); public static final int INVALID_CHECKSUM_LEN = INVALID_CHECKSUM_MSG.length; public static final byte[] INVALID_MESSAGE = toAscii("8=FIX.4.2\0019=145\00135=D\00134=4\00149=ABC_DEFG01\001" + - "52=\\\\\20156=CCG\001115=XYZ\00111=NF 0542/03232009\001\001\001\001\001\00154=1\00138=55140=" + - "\00159=0\00147=A\00160=20090323-15:40:29\00121=1\001207=N\00110=194\001"); + "52=\\\\\20156=CCG\001115=XYZ\00111=NF 0542/03232009\001\001\001\001\001\00154=1\00138=55140=" + + "\00159=0\00147=A\00160=20090323-15:40:29\00121=1\001207=N\00110=194\001"); public static final int INVALID_LEN = INVALID_MESSAGE.length; public static final byte[] EXECUTION_REPORT = toAscii("8=FIX.4.2\0019=378\00135=8\001128=XYZ\00134=5\00149=CCG" + - "\00156=ABC_DEFG01\00152=20090323-" + - "15:40:35\00155=CVS\00137=NF 0542/03232009\00111=NF 0542/03232009\00117=NF 0542/03232009" + - "001001001\00120=0\00139=2\001150=2\00154=1\00138=100\00140=1\00159=0\00131=25.4800\00132=100\001" + - "14=0\0016=0\001151=0\00160=20090323-15:40:30\00158=Fill\00130=N\00176=0034\001207=N\00147=A\001" + - "9430=NX\0019483=000008\0019578=1\001382=1\001375=TOD\001337=0000\001437=100\001438=1243\001" + - "9579=0000100001\0019426=2/2\0019433=0034\00129=1\00163=0\0019440=001001001\00110=080\001"); + "\00156=ABC_DEFG01\00152=20090323-" + + "15:40:35\00155=CVS\00137=NF 0542/03232009\00111=NF 0542/03232009\00117=NF 0542/03232009" + + "001001001\00120=0\00139=2\001150=2\00154=1\00138=100\00140=1\00159=0\00131=25.4800\00132=100\001" + + "14=0\0016=0\001151=0\00160=20090323-15:40:30\00158=Fill\00130=N\00176=0034\001207=N\00147=A\001" + + "9430=NX\0019483=000008\0019578=1\001382=1\001375=TOD\001337=0000\001437=100\001438=1243\001" + + "9579=0000100001\0019426=2/2\0019433=0034\00129=1\00163=0\0019440=001001001\00110=080\001"); public static final byte[] ZERO_REPEATING_GROUP = toAscii("8=FIX.4.2\0019=378\00135=8\001128=XYZ\00134=5\00149=CCG" + - "\00156=ABC_DEFG01\00152=20090323-" + - "15:40:35\00155=CVS\00137=NF 0542/03232009\00111=NF 0542/03232009\00117=NF 0542/03232009" + - "001001001\00120=0\00139=2\001150=2\00154=1\00138=100\00140=1\00159=0\00131=25.4800\00132=100\001" + - "14=0\0016=0\001151=0\00160=20090323-15:40:30\00158=Fill\00130=N\00176=0034\001207=N\00147=A\001" + - "9430=NX\0019483=000008\0019578=1\001382=0\001" + - "9579=0000100001\0019426=2/2\0019433=0034\00129=1\00163=0\0019440=001001001\00110=080\001"); + "\00156=ABC_DEFG01\00152=20090323-" + + "15:40:35\00155=CVS\00137=NF 0542/03232009\00111=NF 0542/03232009\00117=NF 0542/03232009" + + "001001001\00120=0\00139=2\001150=2\00154=1\00138=100\00140=1\00159=0\00131=25.4800\00132=100\001" + + "14=0\0016=0\001151=0\00160=20090323-15:40:30\00158=Fill\00130=N\00176=0034\001207=N\00147=A\001" + + "9430=NX\0019483=000008\0019578=1\001382=0\001" + + "9579=0000100001\0019426=2/2\0019433=0034\00129=1\00163=0\0019440=001001001\00110=080\001"); public static final byte[] REPEATING_GROUP = toAscii("8=FIX.4.2\0019=190\00135=E\00149=INST\00156=BROK\001" + - "52=20050908-15:51:22\00134=200\00166=14\001394=1\00168=2\001" + - "73=2\001" + - "11=order-1\00167=1\00155=IBM\00154=2\00138=2000\00140=1\001" + - "11=order-2\00167=2\00155=AOL\00154=2\00138=1000\00140=1\001"); + "52=20050908-15:51:22\00134=200\00166=14\001394=1\00168=2\001" + + "73=2\001" + + "11=order-1\00167=1\00155=IBM\00154=2\00138=2000\00140=1\001" + + "11=order-2\00167=2\00155=AOL\00154=2\00138=1000\00140=1\001"); // See http://fixwiki.org/fixwiki/FPL:Tag_Value_Syntax#Example_of_nested_repeating_group for details public static final byte[] NESTED_REPEATING_GROUP = toAscii("8=FIX.4.2\0019=190\00135=E\00149=INST\00156=BROK\001" + - "52=20050908-15:51:22\00134=200\00166=14\001394=1\00168=2\001" + - "73=2\001" + // NoOrders Group - "11=order-1\00167=1\00155=IBM\00154=2\00138=2000\00140=1\001" + - "78=2\001" + // NoAllocs nested group - "79=bob\001467=10\001366=4\001" + - "79=sally\001467=11\001366=5\001" + - "11=order-2\00167=2\00155=AOL\00154=2\00138=1000\00140=1\001"); + "52=20050908-15:51:22\00134=200\00166=14\001394=1\00168=2\001" + + "73=2\001" + // NoOrders Group + "11=order-1\00167=1\00155=IBM\00154=2\00138=2000\00140=1\001" + + "78=2\001" + // NoAllocs nested group + "79=bob\001467=10\001366=4\001" + + "79=sally\001467=11\001366=5\001" + + "11=order-2\00167=2\00155=AOL\00154=2\00138=1000\00140=1\001"); public static final byte[] INVALID_LENGTH_MESSAGE = toAscii( "8=FIX.4.4\0019=5\00135=A\00134=1\00149=TW\00152=20150604-12:46:54\00156=ISLD\00198=0\00110=000\001"); public static final byte[] ZERO_CHECKSUM_MESSAGE = toAscii( "8=FIX.4.4\0019=0067\00135=0\00149=acceptor\00156=initiator\00134=2" + - "\00152=20160415-12:50:23.294\001112=hi\00110=000\001"); + "\00152=20160415-12:50:23.294\001112=hi\00110=000\001"); public static final int NO_ORDERS = 73; public static final int NO_ALLOCS = 78; diff --git a/artio-core/src/main/java/uk/co/real_logic/artio/engine/LowResourceEngineScheduler.java b/artio-core/src/main/java/uk/co/real_logic/artio/engine/LowResourceEngineScheduler.java index 260d3f5720..580c6a789d 100644 --- a/artio-core/src/main/java/uk/co/real_logic/artio/engine/LowResourceEngineScheduler.java +++ b/artio-core/src/main/java/uk/co/real_logic/artio/engine/LowResourceEngineScheduler.java @@ -117,7 +117,7 @@ public void configure(final Aeron.Context aeronContext) /** * Adapt a recording coordinator to the Agent interface to enable it to be shutdown in order. */ - private class RecordingCoordinatorAgent implements Agent + private final class RecordingCoordinatorAgent implements Agent { @Override public int doWork() diff --git a/artio-core/src/main/java/uk/co/real_logic/artio/engine/framer/PasswordCleaner.java b/artio-core/src/main/java/uk/co/real_logic/artio/engine/framer/PasswordCleaner.java index a05b8c1027..8ce32bf30c 100644 --- a/artio-core/src/main/java/uk/co/real_logic/artio/engine/framer/PasswordCleaner.java +++ b/artio-core/src/main/java/uk/co/real_logic/artio/engine/framer/PasswordCleaner.java @@ -165,7 +165,7 @@ public int cleanedLength() return cleanedLength; } - private class FieldScanner implements OtfMessageAcceptor + private final class FieldScanner implements OtfMessageAcceptor { public MessageControl onNext() { diff --git a/artio-core/src/test/java/uk/co/real_logic/artio/engine/PossDupFinderTest.java b/artio-core/src/test/java/uk/co/real_logic/artio/engine/PossDupFinderTest.java index 08e167d92b..d4c8711f38 100644 --- a/artio-core/src/test/java/uk/co/real_logic/artio/engine/PossDupFinderTest.java +++ b/artio-core/src/test/java/uk/co/real_logic/artio/engine/PossDupFinderTest.java @@ -13,11 +13,11 @@ public class PossDupFinderTest { private static final byte[] FIRST_MESSAGE = ("8=FIX.4.4\0019=0065\00135=5\00149=initiator\00156=acceptor\00134=2\001" + - "52=20161206-11:04:51.461\00110=088\001").getBytes(US_ASCII); + "52=20161206-11:04:51.461\00110=088\001").getBytes(US_ASCII); private static final byte[] SECOND_MESSAGE = ("8=FIX.4.4\0019=0065\00135=5\00149=initiator\00156=acceptor\00134=2\001" + - "52=20161206-11:04:51.461\00143=Y\00110=088\001").getBytes(US_ASCII); + "52=20161206-11:04:51.461\00143=Y\00110=088\001").getBytes(US_ASCII); private final PossDupFinder possDupFinder = new PossDupFinder(); private final OtfParser parser = new OtfParser(possDupFinder, new LongDictionary()); diff --git a/artio-core/src/test/java/uk/co/real_logic/artio/engine/logger/ReplayerTest.java b/artio-core/src/test/java/uk/co/real_logic/artio/engine/logger/ReplayerTest.java index 6c3874020d..39506e9deb 100644 --- a/artio-core/src/test/java/uk/co/real_logic/artio/engine/logger/ReplayerTest.java +++ b/artio-core/src/test/java/uk/co/real_logic/artio/engine/logger/ReplayerTest.java @@ -79,7 +79,7 @@ public class ReplayerTest extends AbstractLogTest public static final byte[] MESSAGE_REQUIRING_LONGER_BODY_LENGTH = ("8=FIX.4.4\0019=99\00135=1\00134=1\00149=LEH_LZJ02\00152=" + ORIGINAL_SENDING_TIME + "\00156=CCG\001" + - "112=a12345678910123456789101234567891012345\00110=005\001").getBytes(US_ASCII); + "112=a12345678910123456789101234567891012345\00110=005\001").getBytes(US_ASCII); private static final int MAX_CLAIM_ATTEMPTS = 100; private static final long CORRELATION_ID = 2; diff --git a/artio-system-tests/src/perf/java/uk/co/real_logic/artio/system_benchmarks/FixBenchmarkServer.java b/artio-system-tests/src/perf/java/uk/co/real_logic/artio/system_benchmarks/FixBenchmarkServer.java index d638ed395c..a270ebcc18 100644 --- a/artio-system-tests/src/perf/java/uk/co/real_logic/artio/system_benchmarks/FixBenchmarkServer.java +++ b/artio-system-tests/src/perf/java/uk/co/real_logic/artio/system_benchmarks/FixBenchmarkServer.java @@ -125,7 +125,7 @@ public void onDisconnect(final FixLibrary library) }); } - private static class BenchmarkAuthenticationStrategy implements AuthenticationStrategy + private static final class BenchmarkAuthenticationStrategy implements AuthenticationStrategy { private static final byte[] INVALID_PASSWORD = "Invalid Password".getBytes(StandardCharsets.US_ASCII); private final ScheduledExecutorService scheduledExecutorService = Executors.newScheduledThreadPool(1);