Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Diagrams/ Graphics on README #1467

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

alo7lika
Copy link
Contributor

@alo7lika alo7lika commented Oct 16, 2024

Description

This pull request adds diagrams and graphics to the README to enhance the documentation and provide a clearer understanding of the project. The inclusion of visual aids aims to improve the user experience by making complex concepts easier to grasp. This change addresses the need for more engaging and informative content as highlighted in issue #1438

Motivation and Context:
Visual representations can significantly aid in the comprehension of machine learning frameworks, libraries, and software, allowing users to quickly grasp key concepts.

Dependencies:

  • matplotlib - For creating visualizations.

Fixes #1438

Type of Change

  • Added a new machine learning framework, library, or software.
  • Documentation update.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@alo7lika
Copy link
Contributor Author

@sanjay-kv the task has been completed.

Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are those pictures. its not relevant or not look like our website

@sanjay-kv
Copy link
Member

can u provide a screen recording of your local run

@alo7lika
Copy link
Contributor Author

what are those pictures. its not relevant or not look like our website

Made some changes @sanjay-kv
kindly Review it

Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more changes requested

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u remove this pic

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this pic

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is duplicate image remove this

@alo7lika
Copy link
Contributor Author

Some more changes requested

Since I'm a beginner, I'm facing issues in removing them, since I don't see any delete option or any option to remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📝[Docs]: ADD Diagrams/ Graphics on README
2 participants