Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the MakeRequest<T> and MakeRequestAsync<T> methods in the BaseClient class to virtual? #662

Open
aleevans opened this issue Oct 12, 2021 · 1 comment
Labels

Comments

@aleevans
Copy link

I'd like to make the generic MakeRequest and MakeRequestAsync methods virtual so that I can override them and more easily add logging in my application. Would this change be possible? Thanks!

@aleevans aleevans changed the title Would it be possible to make the MakeRequest and MakeRequestAsync methods in the BaseClient class virtual? Change the MakeRequest<T> and MakeRequestAsync<T> methods in the BaseClient class to virtual? Oct 12, 2021
@rer7891
Copy link
Contributor

rer7891 commented Oct 21, 2021

@aleevans Thank you for bringing this to our attention. I will make a feature request for this issue. This will be put in our backlog so in the meantime if you need the functionality sooner than our engineers are able to get to it feel free to consider making a PR for the features you would like added. As an open source repository we are always happy to work with engineers on PRs that are submitted. Otherwise we will follow up once the feature request is picked up and the new feature is ready for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants