Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: add positional argument for type to release create #152

Open
pbabinca opened this issue Feb 21, 2019 · 0 comments
Open

RFE: add positional argument for type to release create #152

pbabinca opened this issue Feb 21, 2019 · 0 comments

Comments

@pbabinca
Copy link

Various release types have different requirements on their options. See e.g. #151. To make use of the tool easier to explain I'm proposing new position argument with type of the release instead of --type option:

errata-tool release create <type> [options]
pbabinca added a commit to pbabinca/errata-tool that referenced this issue Feb 21, 2019
@pbabinca
release: type of release is positional argument
749be6a 
Fixes red-hat-storage#152
pbabinca added a commit to pbabinca/errata-tool that referenced this issue Feb 21, 2019
@pbabinca
release: type of release is positional argument
2a024ff 
Before this change:

    $ errata-tool release create -h
    usage: errata-tool release create [-h] --name NAME --product PRODUCT
                                      --product_version PRODUCT_VERSION --type
                                      TYPE --program_manager PROGRAM_MANAGER
                                      --blocker_flags BLOCKER_FLAGS
                                      --default_brew_tag DEFAULT_BREW_TAG

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --type TYPE           eg. "QuarterlyUpdate"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"

After this change:

    $ errata-tool release create --help
    usage: errata-tool release create [-h] {ystream,zstream,async} ...

    positional arguments:
      {ystream,zstream,async}

    optional arguments:
      -h, --help            show this help message and exit

and for each subcommand, e.g. ystream:

    $ errata-tool release create ystream --help
    usage: errata-tool release create ystream [-h] --name NAME --product PRODUCT
                                              --product_version PRODUCT_VERSION
                                              --program_manager PROGRAM_MANAGER
                                              --blocker_flags BLOCKER_FLAGS
                                              --default_brew_tag DEFAULT_BREW_TAG

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"

and similarly same for zstream and async.

Fixer red-hat-storage#152
pbabinca added a commit to pbabinca/errata-tool that referenced this issue Feb 21, 2019
@pbabinca
release: type of release is positional argument
a1ce4a2 
Before this change:

    $ errata-tool release create -h
    usage: errata-tool release create [-h] --name NAME --product PRODUCT
                                      --product_version PRODUCT_VERSION --type
                                      TYPE --program_manager PROGRAM_MANAGER
                                      --blocker_flags BLOCKER_FLAGS
                                      --default_brew_tag DEFAULT_BREW_TAG

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --type TYPE           eg. "QuarterlyUpdate"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"

After this change:

    $ errata-tool release create --help
    usage: errata-tool release create [-h] {ystream,zstream,async} ...

    positional arguments:
      {ystream,zstream,async}

    optional arguments:
      -h, --help            show this help message and exit

and for each subcommand, e.g. ystream:

    $ errata-tool release create ystream --help
    usage: errata-tool release create ystream [-h] --name NAME --product PRODUCT
                                              --product_version PRODUCT_VERSION
                                              --program_manager PROGRAM_MANAGER
                                              --blocker_flags BLOCKER_FLAGS
                                              --default_brew_tag DEFAULT_BREW_TAG

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"

and similarly same for zstream and async.

Fixer red-hat-storage#152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbabinca