Create Lifecycle rules (S3) #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanjalKatiyar
force-pushed
the
lifecycle_config
branch
8 times, most recently
from
77f45b7 to
3cc3e8b
Compare
SanjalKatiyar
changed the title
SanjalKatiyar
requested review from
alfonsomthd,
GowthamShanmugam and
bipuladh
alfonsomthd
reviewed
Feb 18, 2025
packages/odf/components/s3-browser/create-lifecycle-rules/CreateLifecycleRule.tsx
Show resolved
Hide resolved
Comment on lines
+405
to
+406
| You have defined{' '} | ||
| <strong>{{ actionsCount }} lifecycle rules.</strong> |
There was a problem hiding this comment.
Shouldn't we use pf-v5-u-mr-xs instead of whitespace separator & pf-v5-u-font-weight-bold instead of strong ?
There was a problem hiding this comment.
{' '} is added by linter.
I am okay with any of pf-v5-u-font-weight-bold or <strong>, I don't have any particular preference between the two.
packages/odf/components/s3-browser/create-lifecycle-rules/validations.ts
Show resolved
Hide resolved
SanjalKatiyar
force-pushed
the
lifecycle_config
branch
from
3cc3e8b to
76eb2b6
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alfonsomthd, SanjalKatiyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 20394fe
into
red-hat-storage:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHSTOR-6951