From 1521079fcf9bc9a4668795b59f4ffa95b710b9f6 Mon Sep 17 00:00:00 2001
From: Nir Soffer <nsoffer@redhat.com>
Date: Thu, 22 Jun 2023 20:01:50 +0300
Subject: [PATCH] Switch test environment to docker driver

The podman driver is flakeky locally and consistently failing in github
actions now. Switching to docker fix the issues in github.

Developers need to install docker to run drenv test locally. I tried to
use the podman-docker pacakge but it does not emulate docker good
enough for minikube.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
(cherry picked from commit d359bb4ecf9b2fb832f4c3246a8c4605c6663377)
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
---
 test/README.md      | 23 ++++++++++++++++-------
 test/envs/test.yaml |  3 +--
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/test/README.md b/test/README.md
index 11c66feb2..cfd5e528d 100644
--- a/test/README.md
+++ b/test/README.md
@@ -37,21 +37,30 @@ environment.
    [Install clusteradm CLI tool](https://open-cluster-management.io/getting-started/installation/start-the-control-plane/#install-clusteradm-cli-tool)
    for the details. Version 0.5.0 or later is required.
 
-1. Install `podman`
+1. Install `docker`
 
    ```
-   sudo dnf install podman
+   sudo dnf install docker
    ```
 
-   Allow yourself to run podman as root without a password by adding
-   this file as root:
+   Add yourself to the `docker` group to allow running docker as root:
 
    ```
-   # cat /etc/sudoers.d/podman
-   # Allow passwordless podman
-   myusername ALL=(ALL) NOPASSWD: /usr/bin/podman
+   sudo usermod -aG docker $USER && newgrp docker
    ```
 
+   Restart docker service to fix the permissions on the docker daemon
+   socket:
+
+   ```
+   sudo systemctl restart docker
+   ```
+
+   For more info see [Linux post-installation steps for Docker Engine](https://docs.docker.com/engine/install/linux-postinstall/).
+
+   docker is used only for running drenv tests locally. You can use
+   podman for building and running containers locally.
+
 ### Testing that drenv is healthy
 
 Run this script to make sure `drenv` works:
diff --git a/test/envs/test.yaml b/test/envs/test.yaml
index 95f1cabcb..fad86038d 100644
--- a/test/envs/test.yaml
+++ b/test/envs/test.yaml
@@ -6,8 +6,7 @@
 name: test
 profiles:
   - name: cluster
-    driver: podman
-    container_runtime: cri-o
+    driver: docker
     memory: 2g
     workers:
       - addons: