From a980eebacb31bb916af47e9a21c703678349686a Mon Sep 17 00:00:00 2001 From: Nir Soffer Date: Tue, 19 Mar 2024 00:23:48 +0200 Subject: [PATCH] Split ramenctl deploy and config ramenctl config is fails from time to time when: - Waiting for policies to propagate to managed clusters - Failing to access ramen webhook when adding a drcluster The first issue may be a bug in ocm that we need to reproduce and investigate locally. The second issue may be a bug in the way we wait for ramen, but I think there is no good way to wait until a webhook is available, it can fail even if the container is running. This issue will be resolved soon by removing the ramen webhooks. This is a temporary error that should be resolved by retrying. Until we resolve both issues, lets retry the config step on errors. Signed-off-by: Nir Soffer --- .github/workflows/e2e.yaml | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index 25b907444..74025d93a 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -51,13 +51,18 @@ jobs: drenv start --max-workers ${{ env.MAX_WORKERS }} --name-prefix ${{ env.NAME_PREFIX }} envs/regional-dr.yaml - name: Deploy ramen - run: | - ramenctl deploy --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml - ramenctl config --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml + run: ramenctl deploy --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml + + - name: Configure ramen + uses: nick-fields/retry@v3 + with: + timeout_seconds: 60 + max_attempts: 3 + command: ramenctl config --name-prefix ${{ env.NAME_PREFIX }} test/envs/regional-dr.yaml - name: Run e2e tests run: | - cp ~/.config/drenv/${{ env.NAME_PREFIX }}rdr/config.yaml ../e2e/config.yaml + cp ~/.config/drenv/${{ env.NAME_PREFIX }}rdr/config.yaml e2e/config.yaml make e2e-rdr - name: Delete clusters