From e6f22e58de8c41b59c51fd4031e5e0607fa99ba8 Mon Sep 17 00:00:00 2001 From: Nir Soffer Date: Mon, 2 Dec 2024 18:35:46 +0200 Subject: [PATCH] Fix typo in progression constant Rename ProgressionCheckingFailoverPrequisites to ProgressionCheckingFailoverPrerequisites and update the progress message. This may break users hard-coding the progression text. Signed-off-by: Nir Soffer --- api/v1alpha1/drplacementcontrol_types.go | 2 +- internal/controller/drplacementcontrol.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/api/v1alpha1/drplacementcontrol_types.go b/api/v1alpha1/drplacementcontrol_types.go index c0cb3dbbc..b533de1af 100644 --- a/api/v1alpha1/drplacementcontrol_types.go +++ b/api/v1alpha1/drplacementcontrol_types.go @@ -102,7 +102,7 @@ const ( ProgressionWaitForReadiness = ProgressionStatus("WaitForReadiness") ProgressionCleaningUp = ProgressionStatus("Cleaning Up") ProgressionWaitOnUserToCleanUp = ProgressionStatus("WaitOnUserToCleanUp") - ProgressionCheckingFailoverPrequisites = ProgressionStatus("CheckingFailoverPrequisites") + ProgressionCheckingFailoverPrerequisites = ProgressionStatus("CheckingFailoverPrerequisites") ProgressionFailingOverToCluster = ProgressionStatus("FailingOverToCluster") ProgressionWaitForFencing = ProgressionStatus("WaitForFencing") ProgressionWaitForStorageMaintenanceActivation = ProgressionStatus("WaitForStorageMaintenanceActivation") diff --git a/internal/controller/drplacementcontrol.go b/internal/controller/drplacementcontrol.go index f837fe47c..640a94b79 100644 --- a/internal/controller/drplacementcontrol.go +++ b/internal/controller/drplacementcontrol.go @@ -452,7 +452,7 @@ func (d *DRPCInstance) switchToFailoverCluster() (bool, error) { addOrUpdateCondition(&d.instance.Status.Conditions, rmn.ConditionPeerReady, d.instance.Generation, metav1.ConditionFalse, rmn.ReasonNotStarted, fmt.Sprintf("Started failover to cluster %q", d.instance.Spec.FailoverCluster)) - d.setProgression(rmn.ProgressionCheckingFailoverPrequisites) + d.setProgression(rmn.ProgressionCheckingFailoverPrerequisites) curHomeCluster := d.getCurrentHomeClusterName(d.instance.Spec.FailoverCluster, d.drClusters) if curHomeCluster == "" { @@ -2240,7 +2240,7 @@ failoverProgressions are used to indicate progression during failover action pro - postFailoverProgressions indicates Progressions that are noted post creating VRG on the failoverCluster preFailoverProgressions := { - ProgressionCheckingFailoverPrequisites, + ProgressionCheckingFailoverPrerequisites, ProgressionWaitForFencing, ProgressionWaitForStorageMaintenanceActivation, }