Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the same signoff for the same resource at the doesn't cause an error. #25

Open
pgagne opened this issue Sep 12, 2022 · 0 comments

Comments

@pgagne
Copy link

pgagne commented Sep 12, 2022

This would seem like more of a feature then a bug, but the main issue is it is inconsistant with the documentation and expected behavior of a signoff string.

Did the following test:

client1> rlock --lock --search-string aws-resource-1 --signoff hold1
client2> rlock --lock --search-string aws-resource-1 --signoff test-so-1
client3> rlock --lock --search-string aws-resource-1 --signoff test-so-1 

I would of expected an error on client 3 about using a signoff string that is already in use. I found that if I tried to lock a different resource (saw aws-resource-2) I did get an error.

When i released hold1 signoff client2 got the lock, released that one, client3 got it.

If this is the behavior we want we should document it as such. Otherwise we should throw an error when it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant