Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate id #8

Open
resonantdoghouse opened this issue Mar 22, 2018 · 0 comments
Open

duplicate id #8

resonantdoghouse opened this issue Mar 22, 2018 · 0 comments

Comments

@resonantdoghouse
Copy link

Be careful setting the id for the 'learn more' link as this is currently causing duplicate id attributes to be on the page which could cause problems e.g. smooth scroll or hooking in some js functionality. It also won't pass a W3C validator.

? '<small class="nav_desc">' . esc_attr( $item->description ) . '</small><a href="' . esc_attr( $item->url ) . '" id="learn-more">Learn More</a>' : '';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant