Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

committee / cmt command #21

Open
ciankehoe opened this issue Jul 24, 2019 · 7 comments · May be fixed by #46
Open

committee / cmt command #21

ciankehoe opened this issue Jul 24, 2019 · 7 comments · May be fixed by #46
Assignees
Labels
enhancement New feature or request hacktoberfest An issue reserved for people in HackerClub.

Comments

@ciankehoe
Copy link
Contributor

committee || cmt - lists all current Redbrick Committee members by rbusername, name and role.

Could implement a feature where you can request specific roles;

!cmt admin

It would then return username, name of every person in that role (maybe a photo/link to redbrick site with more info about that person if we want to look at that further down the line).

@theycallmemac theycallmemac added enhancement New feature or request help wanted Extra attention is needed labels Jul 24, 2019
@theycallmemac
Copy link
Member

We might actually have an API endpoint on the website for this

https://github.com/redbrick/static-site - I'll investigate and get back to you.

@theycallmemac
Copy link
Member

Okay so an endpoint exists for this! https://www.redbrick.dcu.ie/api/committee

But.. it retrieves the committee of 2017-28. I've raised an issue for it here - might get around to it eventually but if you want to have a look at it @ciankehoe you're more than welcome! I'm assigning this issue to you now anyways. Once it's fixed it's a simple bit of code.

@theycallmemac theycallmemac removed the help wanted Extra attention is needed label Jul 25, 2019
@theycallmemac
Copy link
Member

I've made a PR to fix this issue. Still requires a review and merge but the API endpoint should work

redbrick/static-site#322

@theycallmemac
Copy link
Member

@ciankehoe I've committed the latest committee details but the api seems to still not be relaying the correct information. May need to make a fix to the static site javascript.

@theycallmemac theycallmemac added the hacktoberfest An issue reserved for people in HackerClub. label Oct 10, 2019
@theycallmemac
Copy link
Member

Making this an issue for HackerClub's Hacktoberfest hub. We can hardcode it once we have the full committee.

@ciankehoe
Copy link
Contributor Author

What's the current status on this given we have a full committee at this point?

@theycallmemac
Copy link
Member

It can be hardcoded for now - iI believe the new site will have an api for current committee :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest An issue reserved for people in HackerClub.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants