Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for signing with Sigstore #90

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

travier
Copy link

@travier travier commented Nov 24, 2023

Description

Add support for signing with Sigstore

Related Issue(s)

Fixes: #89

Checklist

  • This PR includes a documentation change
  • This PR does not need a documentation change

  • This PR includes test changes
  • This PR's changes are already tested

  • This change is not user-facing
  • This change is a patch change
  • This change is a minor change
  • This change is a major (breaking) change

Changes made

README: Fix Markdown lints and typos


Add support for signing with Sigstore

Fixes: #89


Update node dependencies: npm audit fix --force


Update bundle: rpm run bundle

@travier
Copy link
Author

travier commented Nov 24, 2023

I'm currently testing this change in this repo: https://github.com/travier/cosign-test

This needs a newer podman version than the one currently available in Ubuntu 22.04 (ubuntu-latest), thus I'm installing it from https://podman.io/docs/installation#ubuntu

@travier
Copy link
Author

travier commented Nov 24, 2023

Error: initializing private key: decrypt: encrypted: unexpected kdf parameters

🤔

Filed as containers/podman#20771.

@travier
Copy link
Author

travier commented Nov 27, 2023

I now have a working setup with https://github.com/travier/podman-action & https://github.com/travier/cosign-test which works with this PR.

Example multi-arch, podman signed build in https://github.com/travier/cosign-test/blob/main/.github/workflows/nginx.yml.

@travier
Copy link
Author

travier commented Jul 11, 2024

This should work once the Ubuntu 24.04 runner images become the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for signing and pushing signatures with sigstore
1 participant