Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementationsCodeLens support for method implementations #3813

Closed
mozhuanzuojing opened this issue Oct 14, 2024 · 3 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#3333 or #3876
Closed
Assignees

Comments

@mozhuanzuojing
Copy link

implementationsCodeLens support impl of method.

Environment
  • Operating System:WSL2 - Ubuntu24.04
  • JDK version:17
  • Visual Studio Code version:1.92
  • Java extension version:1.35.1
Steps To Reproduce

image

[Please attach a sample project reproducing the error]
Please attach logs

Current Result

method of interface don't have impl when enable implementationsCodeLens

Expected Result

find impl of method when enable implementationsCodeLens

Additional Informations
@iwangbowen
Copy link

iwangbowen commented Oct 15, 2024

从你的配置文件里面学到了Java插件的一些特性👍

@mozhuanzuojing
Copy link
Author

I would like to ask how feasible this implementation is, and if it can be implemented, it can reduce the psychological burden of developing a lot of code

@rgrunber rgrunber changed the title 【new feature】 implementationsCodeLens support impl of method implementationsCodeLens support for method implementations Oct 29, 2024
@rgrunber
Copy link
Member

It can definitely be done.
image

See #416 for the history. We would have to have it guarded by a setting since I would see it affecting performance. Something like :

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment