Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public API methods removed by mistake when introducing RedisJSON #3070

Closed
tishun opened this issue Dec 4, 2024 · 0 comments
Closed

Public API methods removed by mistake when introducing RedisJSON #3070

tishun opened this issue Dec 4, 2024 · 0 comments
Milestone
6.5.2.RELEASE

Comments

@tishun
Copy link
Collaborator

tishun commented Dec 4, 2024 •
edited
Loading

Bug Report

See redis/lettucemod#62
See #3054
See #2933

The implementation of the RedisJSON commands introduced a new parser abstraction.
It is required to construct certain objects from the public API, but it used to not be part of the contract.

Current Behavior

The implementation of the RedisJSON commands introduced a new parser abstraction.
It is required to construct certain objects from the public API, but it used to not be part of the contract.

Expected behavior/code

Similarly to #3054 we need to restore the missing constructors and use the default parser.

Environment

  • Lettuce version(s): 6.5.1.RELEASE, 6.5.0.RELEASE
  • Redis version: any

Possible Solution

As a temporary workaround the DEFAULT_JSON_PARSER could be provided, see #3065
@tishun tishun mentioned this issue Dec 4, 2024
Closed
@tishun tishun added this to the 6.5.2.RELEASE milestone Dec 13, 2024
@tishun tishun mentioned this issue Dec 30, 2024
Merged
4 tasks
tishun added a commit that referenced this issue Dec 30, 2024
@tishun
Public API methods removed by mistake when introducing RedisJSON #3070 (
334a84d 
#3108)

* Reverting some of the public constructors that were changed

* Restore public contracts
tishun added a commit to tishun/lettuce-core that referenced this issue Dec 30, 2024
@tishun
Public API methods removed by mistake when introducing RedisJSON redi…
95adf15 
…s#3070 (redis#3108)

* Reverting some of the public constructors that were changed

* Restore public contracts
@tishun tishun mentioned this issue Dec 30, 2024
Merged
4 tasks
tishun added a commit that referenced this issue Dec 30, 2024
@tishun
Public API methods removed by mistake when introducing RedisJSON #3070 (
97fc827 
#3108) (#3109)

* Reverting some of the public constructors that were changed

* Restore public contracts
@tishun tishun closed this as completed Dec 30, 2024
thachlp pushed a commit to thachlp/lettuce that referenced this issue Dec 31, 2024
@tishun @thachlp
Public API methods removed by mistake when introducing RedisJSON redi…
76b52c5 
…s#3070 (redis#3108) (redis#3109)

* Reverting some of the public constructors that were changed

* Restore public contracts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.2.RELEASE
Development

No branches or pull requests
1 participant
@tishun