All the methods which were moved from pre should be @staticmethod as they don't require/modify the Preprocessor object.
#154
Comments
Rykath
added a commit
to Rykath/profit
that referenced
this issue
Oct 17, 2022
test all Postprocessors test the TemplatePreprocessor fix redmod-team#154: make TemplatePreprocessor methods to classmethods where possible this allows someone to create a subclass of the Template Preprocessor and override just some methods Component.wrap (Pre-, Postprocessor & Worker) now uses functools.wraps sets various metadata, e.g. the function name
Merged
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All the methods which were moved from
preshould be@staticmethodas they don't require/modify the Preprocessor object.Alternatively it might even be better to move the whole Template-Preprocessor and it's associated functions (and maybe even the Preprocessor ABC) into their own file.
Originally posted by @Rykath in #153 (comment)
The text was updated successfully, but these errors were encountered: