From b15123383bee6dbaaf65c2470e0abb61b6f7f651 Mon Sep 17 00:00:00 2001 From: hkonsti <45428767+hkonsti@users.noreply.github.com> Date: Tue, 12 Mar 2024 11:46:50 +0100 Subject: [PATCH 1/3] docs: update --- CONTRIBUTING.md | 130 ------------------------------------------------ FUNDING.yml | 4 -- README.md | 37 ++++++++------ SECURITY.md | 9 ++-- 4 files changed, 27 insertions(+), 153 deletions(-) delete mode 100644 CONTRIBUTING.md delete mode 100644 FUNDING.yml diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md deleted file mode 100644 index bb32d943..00000000 --- a/CONTRIBUTING.md +++ /dev/null @@ -1,130 +0,0 @@ -# Contributing to Motion Canvas - -This is an initial version of the Contribution Guide. Feel free to discuss it -and suggest any changes on [our discord server][discord]. - -## Code of Conduct - -Before contributing to the project, please read our -[Code of Conduct](./CODE_OF_CONDUCT.md). - -## Reporting a bug - -Before you submit an issue, please search [the issue tracker][issues]. An issue -for your problem might already exist and the discussion might inform you of -workarounds readily available. - -You can file new issues by [selecting an issue template][new-issue] and filling -out the necessary information. - -## Proposing a Change - -If you intend to change the public API, make any non-trivial changes to the -implementation, or create brand-new guides in the documentation, make sure to -[create an issue][new-feature] first. This will let us discuss a proposal before -you put significant effort into it. After a proposal has been discussed it may -receive the [`c-accepted`][label-accepted] label indicating that it's ready to -be implemented. - -If you're only fixing a bug or a typo, it's fine to submit a pull request right -away without creating an issue, but make sure it contains a clear and concise -description of the bug. - -## Working on Issues - -Before you start working on an issue make sure that it has been accepted -(indicated by a [`c-accepted`][label-accepted] label) and that no one has -claimed it yet. Otherwise, you may duplicate other people's efforts. If somebody -claims an issue but doesn't follow up for more than two weeks, it’s fine to take -it over, but you should still leave a comment. You should also leave a comment -on any issue you're working on, to let others know. - -## Semantic Versioning - -Motion Canvas follows [semantic versioning][semver]. - -## Making a Pull Request - -1. Fork the revideo/revideo repo. -2. In your forked repo, create a new branch for your changes: - ```shell - git checkout -b my-fix-branch main - ``` -3. Update the code. -4. Commit your changes using a **descriptive commit message** that follows the - [Angular Commit Message Conventions][commit-format]. We strongly discourage - using AI to generate commit descriptions. If you believe the description is - not worth writing then it's probably not necessary. - ```shell - git commit --all - ``` - When committing the changes, our git hooks should automatically run Prettier - and ESLint for you. If, for some reason, hooks are not supported in your - working environement, you can run these tools using `npm run prettier:fix` - and `npm run eslint:fix` respectively. -5. Push your branch to GitHub: - ```shell - git push origin my-fix-branch - ``` -6. In GitHub, send a pull request to [the main branch][main] and **request a - review** from [aarthificial](https://github.com/aarthificial). - -### Going through verification - -After you made a pull request, a GitHub workflow will be dispatched to verify -it. There are a few checks that can fail: - -| Check name | Description | -| ----------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | -| `Prepare` | Something bad happened when preparing your pull request for verification. This is most likely a problem with our pipeline so make sure to notify us about it. | -| `Commit message` | The commit message doesn't follow the [Angular Commit Message Conventions][commit-format]. You can ignore this check since maintainers can modify your commit message before merging, but make sure to follow the conventions in the future. | -| `Lint` | ESLint has failed. Run `npm run eslint` locally to list the problems. | -| `Code style` | The code is not correctly formatted. Run `npm run prettier:fix` locally to fix the formatting issues. | -| `Build` | The build process failed. Run `npx lerna run build` locally to see the errors. | -| `Unit tests` | Unit tests failed. Run `npx lerna run test` locally to see the which tests are failing and fix them. | -| `Examples` | The examples failed to build. Run `npm run examples:build` locally to see the errors. | -| `E2E` | End-to-end tests failed to build. Run `npm run examples:build` locally to see the errors. | -| `Documentation` | The documentation website failed to build. Run `npm run docs:build` locally to see the errors. | - -### Addressing review feedback - -1. Make required updates to the code. -2. Create a fixup commit and push it to your GitHub repo: - ```shell - git commit --all --fixup HEAD - git push - ``` - -## Using generative AI - -Using generative AI to help you write code and documentation is allowed, but use -it to enhance your work, not replace it. Pull requests that are a mindless copy -of the output of an AI model will be rejected. - -## Getting the _Contributor_ Discord role - -After one of your pull requests has been merged, you can receive the -_Contributor_ role on [our discord server][discord]. To do that, create a -[secret gist][gist] on GitHub and DM one of the server moderators with the link. -This will let us verify that you're the author of the pull request. - -## Attribution - -This Contribution Guide was partially inspired by [React][react] and -[Angular][angular]. - -[semver]: https://semver.org/ -[discord]: https://chat.motioncanvas.io -[semantic-release]: - https://semantic-release.gitbook.io/semantic-release/support/faq#can-i-set-the-initial-release-version-of-my-package-to-0.0.1 -[main]: https://github.com/revideo/revideo/tree/main -[issues]: https://github.com/revideo/revideo/issues -[new-issue]: https://github.com/revideo/revideo/issues/new/choose -[new-feature]: - https://github.com/revideo/revideo/issues/new?template=feature_request.md -[commit-format]: - https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit -[angular]: https://github.com/angular/angular/blob/main/CONTRIBUTING.md -[react]: https://reactjs.org/docs/how-to-contribute.html -[label-accepted]: https://github.com/revideo/revideo/labels/c-accepted -[gist]: https://gist.github.com/ diff --git a/FUNDING.yml b/FUNDING.yml deleted file mode 100644 index c7c20b14..00000000 --- a/FUNDING.yml +++ /dev/null @@ -1,4 +0,0 @@ -# These are supported funding model platforms - -github: [aarthificial] -patreon: aarthificial diff --git a/README.md b/README.md index b61d0907..a2595412 100644 --- a/README.md +++ b/README.md @@ -15,24 +15,29 @@