storage: add LogCompactionSchedulingTest::dirty_ratio_scheduling_test ducktape test
#25205
+233
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For encapsulating some generic functions that will be shared between future log compaction ducktape classes.
This assert on `get_closed_segment_bytes()` is race-y in the parameterized test which uses a `compact,delete` cleanup policy. This is because it is possible for retention to kick in after waiting on compaction, and fully remove all closed bytes in the log. Remove this assert to de-flake the test.
This test stresses the dirty ratio, as well as the use of `min.cleanable.dirty.ratio` for scheduling compaction.
CI test resultstest results on build#62420
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new test that asserts that compaction scheduling is properly controlled by the
min.cleanable.dirty.ratiotopic/cluster property, and thedirty_ratio()of a log.This also includes a commit to refactor some shared utils between
LogCompactionTestand the newLogCompactionSchedulingTestinto parent classLogCompactionTestBase.Also remove a race-y
assertinlog_compaction_test.py: https://redpandadata.atlassian.net/browse/CORE-9059Backports Required
Release Notes