You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Hi, I'm wondering if it'd be useful to recognize pronouns other than the subject from existing sets when parsing a string.
Right now pronouns('they') returns the they/them pronouns object, but pronouns('them') assumes that 'them' is a subject pronoun and returns a new object. I think better default behavior would be for pronouns('them') to return the same object as pronouns('they'). My use case is to be (more readily) able to swap one pronoun for another while maintaining the grammar of a sentence (for templating, basically).
If this sounds like a good idea I'd be down to look at the code and submit a pull request. Could also preserve the default behavior and allow this using an option arg or a new method, to avoid breaking changes.
The text was updated successfully, but these errors were encountered:
hi, thank you for bringing this up! right now the functionality you want exists in spaghetti code on the parsing-improvements branch for a future version 2, but i lost motivation because i wasn't sure anyone was actually using it. turns out i was wrong :)
i can commit the unfinished code i have on my computer and if you'd like to take a look at #7 and possibly contribute code i would appreciate it greatly!
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi, I'm wondering if it'd be useful to recognize pronouns other than the subject from existing sets when parsing a string.
Right now
pronouns('they')
returns the they/them pronouns object, butpronouns('them')
assumes that 'them' is a subject pronoun and returns a new object. I think better default behavior would be forpronouns('them')
to return the same object aspronouns('they')
. My use case is to be (more readily) able to swap one pronoun for another while maintaining the grammar of a sentence (for templating, basically).If this sounds like a good idea I'd be down to look at the code and submit a pull request. Could also preserve the default behavior and allow this using an option arg or a new method, to avoid breaking changes.
The text was updated successfully, but these errors were encountered: